507338 - [WinCE] updater.exe update in progress dialog isn't displayed

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

It hasn't been implemented as of yet.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress rev1

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: screenshot of updater on Fennec in an emulator

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: screenshot of updater on Fennec in an emulator complete

Shows that the update dialog is centered

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress rev2

Still needs to handle device screen dimensions smaller than the dialog. There is also a strange bug when running this on the nv device in that ResizeDialogToFit subsequent code to fail though it does work if there is a MessageBox just after the call to DrawText while this works fine in an emulator. *scratches head*

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

After getting everything working on an emulator I tested on an nv device and ended up running into a couple of idiosyncrasies with it.

SendDlgItemMessage wasn't working so I switched to using GetDlgItem and SendMessage.
Nothing after the ResizeDialogToFit function was called. Turned out that even though the call to DrawText was succeeding CE would bail later on. Using szwInfo fixed this.

I went with a smaller dialog in updater.rc for WINCE since the screen real estate is smaller... it is resized as needed. I still need to handle resizing using multiple lines when there isn't enough screen real estate but I'd prefer to do that in another bug.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 394150 [details] [diff] [review]
patch rev1

Brad, could you also review this? Thanks

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 394150 [details] [diff] [review]
patch rev1


>+OS_LIBS += $(call EXPAND_LIBNAME,commctrl ws2)
>+DEFINES += -DUNICODE -D_UNICODE -DWINCE

We should have WINCE defined in autoconf.mk.  Also, arm-wince-gcc defines UNICODE.  Is this needed for RC?

Comment 8

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2 - use separate rc file for WINCE

It was needed for the RC but since the RC had so many ifdefs I went with a separate one for WINCE to clean it up a bit.

Comment 9

[Robert Strong (they/them - no direct email)]

Attachment: patch rev3 - also fixes bug 508905

forgot to add the fix for bug 508905

Comment 10

[Robert Strong (they/them - no direct email)]

Filed bug 510162 for using multiple lines for the info text when appropriate.

Comment 11

[Robert Strong (they/them - no direct email)]

Requesting blocking... we need this to show the updater ui for nv.

Comment 12

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/546a7d596966

Comment 13

[Robert Strong (they/them - no direct email)]

pushed to mozilla-1.9.2
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b660ab28fc27

Comment 14

[Marcia Knous [:marcia]]

Verified fixed on 1.9.2 using Mozilla/5.0 (Windows; U; WindowsCE 6.0; en-US;
rv:1.9.2a2pre) Gecko/20090905 Firefox/3.6a2pre. Adding keyword.