filter dialog unusable when opened in smart folders mode

RESOLVED FIXED in Thunderbird 3.0b4

Status

defect
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: mkmelin, Assigned: rkent)

Tracking

Trunk
Thunderbird 3.0b4
Bug Flags:
blocking-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Reporter

Description

10 years ago
Tools | Message Filters is unusable if you open it in smart folders mode.

Error: uncaught exception: unable to find folder to select!

Error: gCurrentFilterList is undefined
Source File: chrome://messenger/content/FilterListDialog.js
Line: 294
Flags: blocking-thunderbird3+
Assignee

Comment 1

10 years ago
Thought I'd give a little effort to a blocker.
Assignee: nobody → kent
Status: NEW → ASSIGNED
Attachment #393407 - Flags: superreview?(bienvenu)
Attachment #393407 - Flags: review?(bienvenu)

Comment 2

10 years ago
thx a lot for looking at this, Kent. Why not change the nsIMsgIncomingServer canHaveFilters attribute to be read write?
Assignee

Comment 3

10 years ago
That would work as well - and I assume that is what you prefer from your question. I don't have a strong opinion, I was just trying to follow as much as possible the existing design, which seemed to be that subclasses were responsible to implement that for themself.

Comment 4

10 years ago
yes, I prefer that - subclasses are one thing, but having a separate interface that essentially overrides the value could be a little confusing.
Assignee

Comment 5

10 years ago
Here's the version doing the change at the parent class instead.
Attachment #393407 - Attachment is obsolete: true
Attachment #394337 - Flags: superreview?(bienvenu)
Attachment #394337 - Flags: review?(bienvenu)
Attachment #393407 - Flags: superreview?(bienvenu)
Attachment #393407 - Flags: review?(bienvenu)

Updated

10 years ago
Attachment #394337 - Flags: superreview?(bienvenu)
Attachment #394337 - Flags: superreview+
Attachment #394337 - Flags: review?(bienvenu)
Attachment #394337 - Flags: review+

Comment 6

10 years ago
Comment on attachment 394337 [details] [diff] [review]
remove readonly from canHaveFilters in nsIMsgIncomingServer

this looks good, but can you add an NS_ENSURE_ARG_POINTER to GetCanHaveFilters for correctness (and Venkman's) sake?
Assignee

Comment 7

10 years ago
Patch to checkin.
Attachment #394337 - Attachment is obsolete: true
Attachment #394344 - Flags: superreview+
Attachment #394344 - Flags: review+
Assignee

Updated

10 years ago
Keywords: checkin-needed
Comment on attachment 394344 [details] [diff] [review]
Fixed nits
[Checkin: Comment 8]


http://hg.mozilla.org/comm-central/rev/6ba55ef79e06
Attachment #394344 - Attachment description: Fixed nits, carrying over r/sr → Fixed nits [Checkin: Comment 8]
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b4
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.