Tools | Message Filters is unusable if you open it in smart folders mode. Error: uncaught exception: unable to find folder to select! Error: gCurrentFilterList is undefined Source File: chrome://messenger/content/FilterListDialog.js Line: 294
Thought I'd give a little effort to a blocker.
thx a lot for looking at this, Kent. Why not change the nsIMsgIncomingServer canHaveFilters attribute to be read write?
That would work as well - and I assume that is what you prefer from your question. I don't have a strong opinion, I was just trying to follow as much as possible the existing design, which seemed to be that subclasses were responsible to implement that for themself.
yes, I prefer that - subclasses are one thing, but having a separate interface that essentially overrides the value could be a little confusing.
Here's the version doing the change at the parent class instead.
Comment on attachment 394337 [details] [diff] [review] remove readonly from canHaveFilters in nsIMsgIncomingServer this looks good, but can you add an NS_ENSURE_ARG_POINTER to GetCanHaveFilters for correctness (and Venkman's) sake?
Patch to checkin.
Comment on attachment 394344 [details] [diff] [review] Fixed nits [Checkin: Comment 8] http://hg.mozilla.org/comm-central/rev/6ba55ef79e06
Attachment #394344 - Attachment description: Fixed nits, carrying over r/sr → Fixed nits [Checkin: Comment 8]
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b4
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.