Closed Bug 507367 Opened 11 years ago Closed 11 years ago

incorrect null check in nsSVGPatternFrame::GetTargetGeometry

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file)

202   if (NS_FAILED(GetTargetGeometry(&callerCTM,
203                                   &callerBBox,
204                                   &callerContent, aSource)))

577 nsSVGPatternFrame::GetTargetGeometry(gfxMatrix *aCTM,
578                                      gfxRect *aBBox,
579                                      nsSVGElement **aTargetContent,
580                                      nsSVGGeometryFrame *aTarget)
581 {
582   *aTargetContent = nsnull;

595 NS_ASSERTION(aTargetContent,"Caller does not have any content!"); 596 if (!aTargetContent) 597 return NS_ERROR_FAILURE;
Severity: enhancement → normal
Summary: useless null check in nsSVGPatternFrame::GetTargetGeometry → incorrect null check in nsSVGPatternFrame::GetTargetGeometry
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #391581 - Flags: review?(jwatt)
Comment on attachment 391581 [details] [diff] [review]
proper null check

r=jwatt

thanks!
Attachment #391581 - Flags: review?(jwatt) → review+
http://hg.mozilla.org/mozilla-central/rev/ffcf0ce77162
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.