507377 - useless null check of params in nsc_parameter_gen

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P5)

Description

[timeless]

2838 nsc_parameter_gen(CK_KEY_TYPE key_type, SFTKObject *key)
2871         rv = PQG_ParamGen(j, &params, &vfy);
2873         rv = PQG_ParamGenSeedLen(j,seedBits/8, &params, &vfy);
2876     if (rv != SECSuccess) {
2880         return sftk_MapCryptError(PORT_GetError());

2882     crv = sftk_AddAttributeType(key,CKA_PRIME,
2883                                  params->prime.data, params->prime.len);
2902     if (params) {

Comment 1

[timeless]

Attachment: patch

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 391589 [details] [diff] [review]
patch

r+
No objection to removal of redundant check, because PQG_DestroyParams won't crash given NULL.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

This patch affects FIPS validated code, so must wait.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

softoken/pkcs11c.c; new revision: 1.111.8.1; previous revision: 1.111