Closed Bug 507404 Opened 11 years ago Closed 11 years ago

dialogWindow is unused in DialogOKClicked and DIALOGID is useless

Categories

(Core :: Plug-ins, enhancement)

x86
Linux
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file, 1 obsolete file)

86 DialogOKClicked (GtkButton *button, gpointer data)
89     GtkWidget* dialogWindow = g_object_get_data(GTK_OBJECT(button), DIALOGID);
Attached patch remove it (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #391622 - Flags: review?(mozbugz)
Summary: dialogWindow is unused in DialogOKClicked → dialogWindow is unused in DialogOKClicked and remove DIALOGID
Summary: dialogWindow is unused in DialogOKClicked and remove DIALOGID → dialogWindow is unused in DialogOKClicked and DIALOGID is useless
Attachment #391622 - Attachment is obsolete: true
Attachment #393724 - Flags: review?(mozbugz)
Attachment #391622 - Flags: review?(mozbugz)
Comment on attachment 393724 [details] [diff] [review]
and kill DIALOGID

Thank you.
Attachment #393724 - Flags: review?(mozbugz) → review+
http://hg.mozilla.org/mozilla-central/rev/de4807724319
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.