Closed
Bug 507404
Opened 16 years ago
Closed 16 years ago
dialogWindow is unused in DialogOKClicked and DIALOGID is useless
Categories
(Core Graveyard :: Plug-ins, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file, 1 obsolete file)
|
1.17 KB,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
86 DialogOKClicked (GtkButton *button, gpointer data)
89 GtkWidget* dialogWindow = g_object_get_data(GTK_OBJECT(button), DIALOGID);
|
||
Comment 2•16 years ago
|
||
All references to DIALOGID should really be removed.
They were added here:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/modules/plugin/samples/default/unix&command=DIFF_FRAMESET&file=nullplugin.c&rev2=1.3&rev1=1.2
But the that destruction change was essentially reverted here:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/modules/plugin/samples/default/unix&command=DIFF_FRAMESET&file=nullplugin.c&rev2=1.7&rev1=1.6
Blocks: 67879
Summary: dialogWindow is unused in DialogOKClicked → dialogWindow is unused in DialogOKClicked and remove DIALOGID
Summary: dialogWindow is unused in DialogOKClicked and remove DIALOGID → dialogWindow is unused in DialogOKClicked and DIALOGID is useless
Attachment #391622 -
Attachment is obsolete: true
Attachment #393724 -
Flags: review?(mozbugz)
Attachment #391622 -
Flags: review?(mozbugz)
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 393724 [details] [diff] [review]
and kill DIALOGID
Thank you.
Attachment #393724 -
Flags: review?(mozbugz) → review+
|
||
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 5•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
|
||
Updated•8 years ago
|
Blocks: coverity-analysis
|
||
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•