Closed Bug 507430 Opened 15 years ago Closed 15 years ago

Implement about:weave

Categories

(Firefox :: Sync, defect, P1)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: hello, Assigned: hello)

References

Details

Attachments

(1 file, 2 obsolete files)

Implement an about:weave page to serve as first-run page, replacing the wizard, and also with status information.
Depends on: 485763
Assignee: nobody → thunder
Priority: -- → P1
Blocks: 442871
Blocks: 506147
Attached patch combined patch v1 (obsolete) — Splinter Review
Navigate to about:weave to test.  Login/logout/account creation is implemented, with status, etc.
Attachment #395496 - Flags: review?
Attachment #395496 - Flags: review? → review?(edilee)
How did you create the patch? It's missing the binary data, but maybe it's because they're not git diffs?

Also, how did you get mconnor's bug 481733 fix as a different changeset?
http://hg.mozilla.org/users/dmills_mozilla.com/about-weave/rev/bc99bccd75a9
http://hg.mozilla.org/labs/weave/rev/3eb68a7b4be8

I merged weave to about-weave and I'll just look at the files there.
ah, yeah I just picked revs and ran hg diff.  I also had a bit of a battle with hg... tomorrow I'll export changesets one by one and reapply to a clean tree.
Attached patch combined patch v1 w/binaries c/8 (obsolete) — Splinter Review
Attachment #395496 - Attachment is obsolete: true
Attachment #395496 - Flags: review?(edilee)
I pushed a number of changes to weave that were kinda independent of the about:weave implementation:
http://hg.mozilla.org/labs/weave/pushloghtml?fromchange=0d9fefc7eaa4&tochange=0cd0be687a0a
remove trailing whitespace, jquery fancybox, remove aboutpage, add about:weave assets from sean, point to blank about:weave, add myk's stringbundle

So now diffing from weave to about-weave results in the attached patch. FYI, my steps:

hg clone weave tmp;cd tmp;id=`hg id -i`;hg pull -u ../about-weave;hg diff -r $id > super.patch
Attachment #395533 - Attachment is obsolete: true
Blocks: 511676
Blocks: 511687
Blocks: 511688
Comment on attachment 395539 [details] [diff] [review]
short combined patch v1

r=Mardak with fixes landed and bugs filed
Attachment #395539 - Flags: review+
http://hg.mozilla.org/labs/weave/pushloghtml?changeset=23e979734065
Pushed to weave with some extra fixes:

http://hg.mozilla.org/labs/weave/rev/fdb6c108571f
Handle createAccount resource exceptions correctly (null ret, throw fail) and cleanup. Check for non-failure in the UI instead of only success 200. 

http://hg.mozilla.org/labs/weave/rev/9dca8b9991c9
Try/catch in checkUsername if resource throws and default to generic-server-error. 

http://hg.mozilla.org/labs/weave/rev/23e979734065
Put in a sorry for the sync settings bubble.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Blocks: 512001
This is not the expected behavior today.  what should be he firstrun page?
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: