Closed Bug 507451 Opened 14 years ago Closed 14 years ago

Accesskey conflict on _R_estart and P_r_eferences

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed
status1.9.1 --- .4-fixed

People

(Reporter: mnyromyr, Assigned: mnyromyr)

Details

(Keywords: verified1.9.1)

Attachments

(1 file)

use P for Preferences
1.41 KB, patch
mossop
: review+
Pike
: review+
benjamin
: approval1.9.2+
dveditz
: approval1.9.1.4+
Details | Diff | Splinter Review 
In the Extensions panel, both the "Restart $app" button above the extension list and the "Preferences" button on a single extension entry sport the accesskey 'R'.
Attachment #391662 - Flags: review?(dao)
Attachment #391662 - Flags: review?(dao) → review?(dtownsend)
Attachment #391662 - Flags: review?(dtownsend) → review+
Comment on attachment 391662 [details] [diff] [review]
use P for Preferences

Thanks, please post a note to mozilla.dev.l10n when you land in case any lcoalisers need to update theirs.
Pushed as <http://hg.mozilla.org/mozilla-central/rev/9651dfcfbd99>.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attachment #391662 - Flags: approval1.9.2?
Attachment #391662 - Flags: approval1.9.1.4?
Comment on attachment 391662 [details] [diff] [review]
use P for Preferences

SeaMonkey-wants+
Comment on attachment 391662 [details] [diff] [review]
use P for Preferences

I don't know if we can take localization changes like this on the stable branch or what it will break. Requesting review from Axel on whether we can go with this or not.
Attachment #391662 - Flags: review?(l10n)
Comment on attachment 391662 [details] [diff] [review]
use P for Preferences

That's fine for branches, with the given post-it sticky note that mossop mentioned.
Attachment #391662 - Flags: review?(l10n) → review+
Attachment #391662 - Flags: approval1.9.1.4? → approval1.9.1.4+
Comment on attachment 391662 [details] [diff] [review]
use P for Preferences

Approved for 1.9.1.4, a=dveditz for release-drivers if you'll send the note described in comment 1
Landed on 1.9.1 branch as <http://hg.mozilla.org/releases/mozilla-1.9.1/rev/24ff6298c986>, posted to md.l10n.
Attachment #391662 - Flags: approval1.9.2? → approval1.9.2+
Landed on 1.9.1 branch as
<http://hg.mozilla.org/releases/mozilla-1.9.2/rev/74750c643c10>, posted to
md.l10n.
Verified for 1.9.1.4 on Ubuntu using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20090921 Shiretoko/3.5.4pre.
Keywords: verified1.9.1
You need to log in before you can comment on or make changes to this bug.