507454 - avmshell commandline args with values can't assume the values are present

Status: VERIFIED FIXED

(Tamarin Graveyard :: Tools, defect, P5)

Description

[Tom Harwood]

This commandline should emit a diagnostic, not segfault:
$AVM -load

Affected args are:
-Dastrace

-cache_bindings
-cache_metadata
-cache_methods
-jitmax
-memlimit
-load
-gcwork
-workers

Comment 1

[Lars T Hansen]

Ah, I see: -load, -gcwork, and -workers check that the argument parses correctly, but not that there actually is an argument.  Duh.

Comment 2

[Tom Harwood]

Attachment: Check for required subsequent arg string as necessary

Tested each arg with and without a valid argument, ran tamarin tests.

Comment 3

[Brent Baker]

Attachment: cmdline testcase

quick cmdline testcases that call the args with no other options. Test is to make sure that there is no segfault, should return "Unrecognized option...."

Tested using build 3475 for passing, and confirmed that build 3285 fails (previous build to change being pushed)

Comment 4

[Dan Schaffer]

Comment on attachment 421039 [details] [diff] [review]
cmdline testcase

cmdline test works. I get 1 failure in tr mainline: on osx I get a Bus Error (10) when running: avmshell -stack

Comment 5

[Brent Baker]

-stack and -Dlanguage still crash the shell, tracked via bug #538969

cmdline testcase pushed in changeset 3484:ea96c237ae6a