507461 - OS/2 remove OS2embed from XULRunner tests

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.2a1pre) Gecko/20090730 Minefield/3.6a1pre
Build Identifier: 

OS2Embed was never ported to be buildable with libxul (for winembed this was done in bug307309 about 4 years ago. I couldn't finally find a definitive answer whether winembed is still supported, but I don't think so.
The only occasion OS2embed should be built is when you compile a test-enabled XULRunner, which must fail. The last OS2Embed that maybe can be compiled is on the 1.8.1 branch.
We should at least remove the lines in xulrunner/build.mk referencing to build OS2embed, maybe we should remove OS2Embed from trunk (and 1.9.1 branch) at all.

Reproducible: Always

Comment 1

[Peter Weilbacher]

I agree that we should remove it. Then we can also close bug 321031. ;-)

At the beginning it served a purpose, but we'll never get anybody interested in embedding Mozilla on OS/2 any more. The last question I got about this was two years ago, and I haven't heard back from that person since then.

Let's see about 1.9.1 once a patch landed in m-c.

Comment 2

[Walter Meinl]

Attachment: remove it

Comment 3

[Peter Weilbacher]

Comment on attachment 391966 [details] [diff] [review]
remove it

Great.

Because of the closed tree, I cannot check this in right now. Please remind me, if I forget.

Comment 4

[Peter Weilbacher]

http://hg.mozilla.org/mozilla-central/rev/65cc2bbfaf39

Comment 5

[Walter Meinl]

Just for the records, XULRunner (including tests) and Firefox-on-top of it are  building fine. I was also able to build os2embed.exe on the 1.8.1 branch and the "example browser" showed nice OS/2 buttons, but that was more or less all what one could do with it.

Comment 6

[Peter Weilbacher]

Comment on attachment 391966 [details] [diff] [review]
remove it

Because this touches cross-platform files I think we should ask for approval.

I don't think there is any risk, because this only removes OS/2 parts from the respective files and hasn't caused any problems on mozilla-central.

Comment 7

[Samuel Sidler (old account; do not CC)]

Comment on attachment 391966 [details] [diff] [review]
remove it

Approved for 1.9.1.3. a=NPOTB, aka ss

Comment 8

[Peter Weilbacher]

Pushed to mozilla-1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3cda74bc0038