507481 - [WinCE] Check for Windows version in download manager shouldn't be done for Windows CE

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Robert Strong (they/them - no direct email)]

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/content/downloads.js#297

This is meant to check for Vista and above.

note: currently system-info is returning 0.0 on Windows CE but once that is fixed this code will treat Windows CE as if it is Vista

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 393469 [details] [diff] [review]
patch rev1

r=sdwilsh

Comment 3

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/4ae548da12d7

Comment 4

[Tony Chung [:tchung]]

(In reply to comment #0)
> http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/content/downloads.js#297
> 
> This is meant to check for Vista and above.
> 
> note: currently system-info is returning 0.0 on Windows CE but once that is
> fixed this code will treat Windows CE as if it is Vista

Rob, how do i verify this fix on the device?

Comment 5

[Robert Strong (they/them - no direct email)]

Tony, I'm not conversant in what this code does exactly... I just know that it should only do it on Vista and above which is what this fixed.

Shawn, perhaps you could give Tony steps for verifying this?

Comment 6

[Shawn Wilsher :sdwilsh]

I suspect the call was throwing an error on the device since those API's don't exist on it, right?

Comment 7

[Robert Strong (they/them - no direct email)]

No, system-info does exist and returns 6 on the nv devices which caused the download manager to think it was running on Vista vs. CE. The difference is that now dontAsk doesn't default to true now on WinCE.

Comment 8

[Shawn Wilsher :sdwilsh]

Sorry - I meant that the security dialog stuff doesn't exist on WINCE.  The pref will be a different value in WINCE than it had before.

Comment 9

[Tony Chung [:tchung]]

(In reply to comment #8)
> Sorry - I meant that the security dialog stuff doesn't exist on WINCE.  The
> pref will be a different value in WINCE than it had before.

Where can i check that pref?   Is there one that you write to about:config that i can easily check?

Comment 10

[Shawn Wilsher :sdwilsh]

The preference is browser.download.manager.alertOnEXEOpen.  Before this bug was fixed, we would not prompt on WINCE about executable files, but now we should (no preferences is written out - I was mistaken in my previous comment).

Comment 11

[Marcia Knous [:marcia]]

I can verify this based on Comment 10 - using 20090918 I do get the dialog when I try to open an executable file. Adding verified keyword.