Closed Bug 507481 Opened 14 years ago Closed 14 years ago

[WinCE] Check for Windows version in download manager shouldn't be done for Windows CE

Categories

(Toolkit :: Downloads API, defect)

ARM
Windows CE
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2b1

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

(Keywords: verified1.9.2, Whiteboard: [nv])

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/content/downloads.js#297

This is meant to check for Vista and above.

note: currently system-info is returning 0.0 on Windows CE but once that is fixed this code will treat Windows CE as if it is Vista
Whiteboard: [nv]
Attached patch patch rev1Splinter Review
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #393469 - Flags: review?(sdwilsh)
Comment on attachment 393469 [details] [diff] [review]
patch rev1

r=sdwilsh
Attachment #393469 - Flags: review?(sdwilsh) → review+
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/4ae548da12d7
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2b1
(In reply to comment #0)
> http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/content/downloads.js#297
> 
> This is meant to check for Vista and above.
> 
> note: currently system-info is returning 0.0 on Windows CE but once that is
> fixed this code will treat Windows CE as if it is Vista

Rob, how do i verify this fix on the device?
Tony, I'm not conversant in what this code does exactly... I just know that it should only do it on Vista and above which is what this fixed.

Shawn, perhaps you could give Tony steps for verifying this?
I suspect the call was throwing an error on the device since those API's don't exist on it, right?
No, system-info does exist and returns 6 on the nv devices which caused the download manager to think it was running on Vista vs. CE. The difference is that now dontAsk doesn't default to true now on WinCE.
Sorry - I meant that the security dialog stuff doesn't exist on WINCE.  The pref will be a different value in WINCE than it had before.
(In reply to comment #8)
> Sorry - I meant that the security dialog stuff doesn't exist on WINCE.  The
> pref will be a different value in WINCE than it had before.

Where can i check that pref?   Is there one that you write to about:config that i can easily check?
The preference is browser.download.manager.alertOnEXEOpen.  Before this bug was fixed, we would not prompt on WINCE about executable files, but now we should (no preferences is written out - I was mistaken in my previous comment).
I can verify this based on Comment 10 - using 20090918 I do get the dialog when I try to open an executable file. Adding verified keyword.
Keywords: verified1.9.2
You need to log in before you can comment on or make changes to this bug.