507506 - ntmisc.c _MD_WindowsGetSysInfo needs to handle Windows CE

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Robert Strong (they/them - no direct email)]

http://mxr.mozilla.org/mozilla-central/source/nsprpub/pr/src/md/windows/ntmisc.c#809

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Wan-Teh Chang]

Comment on attachment 391726 [details] [diff] [review]
patch rev1

r=wtc.  Thanks for the patch.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Remember, the reference copy of NSPR is in CVS, and all other repositories
are downstream.  This fix must be applied to CVS first, then ...

Comment 4

[(not currently active) Ted Mielczarek]

I checked this in to NSPR CVS HEAD for you:
Checking in pr/src/md/windows/ntmisc.c;
/cvsroot/mozilla/nsprpub/pr/src/md/windows/ntmisc.c,v  <--  ntmisc.c
new revision: 3.26; previous revision: 3.25
done

Comment 5

[Robert Strong (they/them - no direct email)]

Thanks Ted

Comment 6

[Christophe Ravel]

This commit broke my build with VC6:

c:/security/securitytip/builds/20090730.1/nssw2000s_WIN/mozilla/nsprpub/pr/src/md/windows/ntmisc.c(843) : error C2065: 'VER_PLATFORM_WIN32_CE' : undeclared identifier
c:/security/securitytip/builds/20090730.1/nssw2000s_WIN/mozilla/nsprpub/pr/src/md/windows/ntmisc.c(843) : error C2051: case expression not constant
make[6]: *** [ntmisc.obj] Error 2

Please back out this change.

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: followup patch

Either VER_PLATFORM_WIN32_CE could be defined locally or the new code can be ifdef WINCE which I kind of prefer since this is only used by WINCE and VER_PLATFORM_WIN32_CE had better be available when compiling WINCE

Comment 8

[Wan-Teh Chang]

Comment on attachment 391940 [details] [diff] [review]
followup patch

r=wtc.  You can also consider just testing the macro in question:

    #ifdef VER_PLATFORM_WIN32_CE

Comment 9

[Wan-Teh Chang]

Here is an example of my suggested change:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/nsprpub/pr/src/md/unix/unix_errors.c&rev=3.28&mark=75-76,95-96,100-101#44

Comment 10

[Robert Strong (they/them - no direct email)]

Attachment: followup patch 2 with Wan-Teh suggestion

Carrying forward review.

Comment 11

[Robert Strong (they/them - no direct email)]

Ted or someone else with access to NSPR CVS... could you please check this in for me? Thanks

Comment 12

[Robert Strong (they/them - no direct email)]

btw: since I don't have a NSPR repo the original patch should be reversed before applying the new patch.

Comment 13

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 392028 [details] [diff] [review]
followup patch 2 with Wan-Teh suggestion

Checked in on CVS trunk
Checking in ntmisc.c; new revision: 3.27; previous revision: 3.26

Robert, in NSPR and NSS, we do not follow the practice (used 
elsewhere in Firefox) of "carrying forward" r+ from prior reviews.
But in this case, I gave it r+ an committed it for you.

Comment 14

[Robert Strong (they/them - no direct email)]

Thanks for the checkin and info Nelson