Created attachment 391763 [details] [diff] [review] Patch jsstr.h A shark session for Chrome Experiments advised to inline some string functions such as isDependent, isFlat, isDeflated....
Comment on attachment 391763 [details] [diff] [review] Patch jsstr.h use inline, not JS_ALWAYS_INLINE. This is C++. Otherwise looks good.
Created attachment 391802 [details] [diff] [review] Patch jsstr.h
Attachment #391763 - Attachment is obsolete: true
There is a bunch of more JS_INLINE_BLA in there. Could you make those "inline" as well. r=me with that. If you upload a fresh patch I will push it for you.
Created attachment 391803 [details] [diff] [review] jsstr.h patch
Comment on attachment 391803 [details] [diff] [review] jsstr.h patch initFlat and dependentIsPrefix() should be all inline too. initPrefix too. Basically all simple methods in the class, especially if they are defined the header file.
Created attachment 391806 [details] [diff] [review] Patch jsstr.h
Comment on attachment 391806 [details] [diff] [review] Patch jsstr.h Now we are talking. Thanks!
Attachment #391806 - Flags: review?(gal) → review+
Severity: normal → enhancement
Priority: -- → P2
Hardware: x86 → All
Should this land in tm or m-c?
Version: unspecified → Trunk
(In reply to comment #8) > Should this land in tm or m-c? My understanding is that all Tracemonkey changes land in the TM repo first, and then Sayre merges them across to m-c.
And either someone needs to actually land it in tracemonkey, or they need to admit they can't be bothered, and wontfix it.
Created attachment 417614 [details] [diff] [review] refresh
Attachment #391806 - Attachment is obsolete: true
Whiteboard: [c-n: tracemonkey] → fixed-in-tracemonkey
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.