507599 - Deleting thousands of lines of text from a textarea emits many warnings

Status: RESOLVED INCOMPLETE

(Core :: Disability Access APIs, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Activate accessibility (e.g. via DOM Inspector)
2. Edit a really large Bugzilla attachment
3 [review]. Try to delete a few thousand lines

Stack backtrace:
nsTextAccessible::AppendTextTo
nsAccUtils::TextLength
nsHyperTextAccessible::DOMPointToHypertextOffset
nsDocAccessible::CreateTextChangeEventForNode
nsDocAccessible::InvalidateCacheSubtree
nsAccessibilityService::InvalidateSubtreeFor
nsGenericElement::doRemoveChildAt
nsGenericElement::RemoveChildAt
nsGenericElement::doRemoveChild
nsGenericElement::RemoveChild
nsGenericElement::RemoveChild
DeleteElementTxn::DoTransaction
EditAggregateTxn::DoTransaction

The aggregate transaction consists (in my test case) of 7956 nodes of which half are <br> nodes and half are text nodes. For each of these nodes, DOMPointToHypertextOffset seems to scan the entire original text, including deleted nodes, which causes millions of warnings in nsTextAccessible::AppendTextTo as the frames are all null.

Comment 1

[Marco Zehe (:MarcoZ)]

Neil, is this still valid?

Comment 2

[[e-mail]]

Looks like something got rewritten along the way and the STR no longer work.

Comment 3

[alexander :surkov (:asurkov)]

(In reply to [e-mail] from comment #2)
> Looks like something got rewritten along the way and the STR no longer work.

yeah, we handle that so differently after Firefox 4. Thanks for checking.