Closed Bug 507727 Opened 10 years ago Closed 10 years ago

Unified toolbars don't work in dialog windows

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Platform:
All
macOS
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file)

v1
1.90 KB, patch
jaas
: review+
Details | Diff | Splinter Review 
When windows are created with the window type eWindowType_dialog, we don't use the ToolbarWindow class for our native NSWindow. This means that those windows don't use our custom title bar drawing and they can't show toolbar collapse buttons.

When you try to use a unified toolbar in those windows, it will look like attachment 375394 [details] (or http://www.twitfactory.com/shots/prefGeneral.png )

I think we should just make nsCocoaWindow.mm treat eWindowType_dialog exactly like eWindowType_toplevel.
Attached patch v1 — — Splinter Review
Attachment #392050 - Flags: review?(joshmoz)
Attachment #392050 - Flags: review?(joshmoz) → review+
http://hg.mozilla.org/mozilla-central/rev/0cfd302c9d58
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.