Unified toolbars don't work in dialog windows

RESOLVED FIXED in mozilla1.9.2a1

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla1.9.2a1
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
When windows are created with the window type eWindowType_dialog, we don't use the ToolbarWindow class for our native NSWindow. This means that those windows don't use our custom title bar drawing and they can't show toolbar collapse buttons.

When you try to use a unified toolbar in those windows, it will look like attachment 375394 [details] (or http://www.twitfactory.com/shots/prefGeneral.png )

I think we should just make nsCocoaWindow.mm treat eWindowType_dialog exactly like eWindowType_toplevel.
(Assignee)

Comment 1

9 years ago
Created attachment 392050 [details] [diff] [review]
v1
Attachment #392050 - Flags: review?(joshmoz)

Updated

9 years ago
Attachment #392050 - Flags: review?(joshmoz) → review+
(Assignee)

Comment 2

9 years ago
http://hg.mozilla.org/mozilla-central/rev/0cfd302c9d58
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.