Closed
Bug 507758
Opened 16 years ago
Closed 16 years ago
filepicker's nsWildCard.cpp (on branches) needs to be updated with the fixes from bug 332173
Categories
(Toolkit :: UI Widgets, defect)
Tracking
()
VERIFIED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.1 | --- | .3-fixed |
People
(Reporter: Waldo, Assigned: Waldo)
References
Details
(Keywords: verified1.9.0.14, verified1.9.1, Whiteboard: [sg:nse] could be sg:crit if we find a way to get to this code from unsanitized content)
Attachments
(1 file)
|
24.13 KB,
patch
|
nelson
:
review+
dveditz
:
approval1.9.1.3+
dveditz
:
approval1.9.0.14+
|
Details | Diff | Splinter Review |
Shouldn't actually be a problem for reasons described in bug 332178 comment 78, but we should still do this for general sanity...
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #392036 -
Flags: review?(nelson)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 392036 [details] [diff] [review]
Patch, includes the character-range followup changes as well
r=nelson
Attachment #392036 -
Flags: review?(nelson) → review+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #392036 -
Flags: approval1.9.0.14?
|
|
Assignee | |
Comment 3•16 years ago
|
||
Comment on attachment 392036 [details] [diff] [review]
Patch, includes the character-range followup changes as well
Good hygiene for the remaining users of the filepicker, even tho the filepicker only uses fixed patterns that aren't affected by any of the past problems with this code...
|
|
Assignee | |
Updated•16 years ago
|
Attachment #392036 -
Flags: approval1.9.1.3?
|
||
Updated•16 years ago
|
Attachment #392036 -
Flags: approval1.9.1.3?
Attachment #392036 -
Flags: approval1.9.1.3+
Attachment #392036 -
Flags: approval1.9.0.14?
Attachment #392036 -
Flags: approval1.9.0.14+
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 392036 [details] [diff] [review]
Patch, includes the character-range followup changes as well
Approved for 1.9.0.14 and 1.9.1.3, a=dveditz for release-drivers
Fixing this copy to match the others is good, but we should file a bug to remove some of these cases and simplify the syntax.
|
|
Assignee | |
Comment 5•16 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/0e95a9429793
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1249597440&maxdate=1249597441
Fixed on branches.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
status1.9.1:
--- → .3-fixed
Keywords: fixed1.9.0.14
Resolution: --- → FIXED
|
||
Comment 6•16 years ago
|
||
Is there a particular means to test this fix or should I not bother? :-)
|
|
Assignee | |
Comment 7•16 years ago
|
||
Don't think there's a way to test it given the constrained ways in which the code is used, so I'd say don't worry about it.
So lets mark it fixed based on the check-ins which happened for both branches.
Status: RESOLVED → VERIFIED
Version: unspecified → 1.9.1 Branch
|
|
||
Updated•16 years ago
|
Depends on: 332173
Flags: wanted1.9.0.x+
Flags: wanted1.8.1.x?
Flags: blocking1.8.1.next?
Whiteboard: [sg:nse] could be sg:crit if we find a way to get to this code from unsanitized content
|
|
||
Updated•16 years ago
|
Group: core-security
|
|
||
Comment 9•16 years ago
|
||
I don't think we need this one fixed on the 1.8 branch, the filepicker is not open to remote setting of the filters.
Flags: wanted1.8.1.x?
Flags: wanted1.8.1.x-
Flags: blocking1.8.1.next?
You need to log in
before you can comment on or make changes to this bug.
Description
•