507881 - remove useless "|| null" fallback in browserGlue.sanitize(window) calls

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

It doesn't make sense. The window objects must exist there.
Also, the Sanitizer.sanitize return value is entirely useless and never looked at.

Comment 1

[Michael Ryan]

_checkAndSanitize in sanitize.js checks if the return value is null, which is strange because that code wasn't even added until after sanitize had been changed to always return null...

Comment 2

[Dão Gottwald [:dao]]

(In reply to comment #1)
> _checkAndSanitize in sanitize.js checks if the return value is null

That's Sanitizer.prototype.sanitize, not Sanitizer.sanitize.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 392133 [details] [diff] [review]
patch

Can you remove the || at http://mxr.mozilla.org/mozilla-central/source/browser/base/content/sanitize.js#493 too?

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> Can you remove the || at
> http://mxr.mozilla.org/mozilla-central/source/browser/base/content/sanitize.js#493
> too?

Sanitizer.prototype.sanitize actually returns an object with errors or null otherwise.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/c116e4a364c8