remove useless "|| null" fallback in browserGlue.sanitize(window) calls

RESOLVED FIXED in Firefox 3.6a1

Status

()

Firefox
General
--
trivial
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 3.6a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 392133 [details] [diff] [review]
patch

It doesn't make sense. The window objects must exist there.
Also, the Sanitizer.sanitize return value is entirely useless and never looked at.
Attachment #392133 - Flags: review?(gavin.sharp)

Comment 1

8 years ago
_checkAndSanitize in sanitize.js checks if the return value is null, which is strange because that code wasn't even added until after sanitize had been changed to always return null...
(Assignee)

Comment 2

8 years ago
(In reply to comment #1)
> _checkAndSanitize in sanitize.js checks if the return value is null

That's Sanitizer.prototype.sanitize, not Sanitizer.sanitize.
Comment on attachment 392133 [details] [diff] [review]
patch

Can you remove the || at http://mxr.mozilla.org/mozilla-central/source/browser/base/content/sanitize.js#493 too?
Attachment #392133 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 4

8 years ago
(In reply to comment #3)
> Can you remove the || at
> http://mxr.mozilla.org/mozilla-central/source/browser/base/content/sanitize.js#493
> too?

Sanitizer.prototype.sanitize actually returns an object with errors or null otherwise.
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/c116e4a364c8
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
You need to log in before you can comment on or make changes to this bug.