Closed
Bug 507897
Opened 15 years ago
Closed 15 years ago
Remove 'WINDOWS16' (support) code everywhere
Categories
(Firefox Build System :: General, defect)
Tracking
(status1.9.2 beta1-fixed)
VERIFIED
FIXED
mozilla1.9.3a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta1-fixed |
People
(Reporter: sgautherie, Assigned: sgautherie)
References
(Depends on 1 open bug, Blocks 1 open bug, )
Details
(Keywords: meta, verified1.9.2)
Attachments
(3 files, 1 obsolete file)
6.30 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
1.90 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
1.08 KB,
patch
|
kairo
:
review+
|
Details | Diff | Splinter Review |
"Found 5 matching lines in 5 files "
Assignee | ||
Comment 1•15 years ago
|
||
(untested, but looks trivial)
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #392150 -
Flags: review?(ted.mielczarek)
Updated•15 years ago
|
Attachment #392150 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 2•15 years ago
|
||
Comment on attachment 392150 [details] [diff] [review] (Av1) version_win.pl [Checkin: Comment 2] http://hg.mozilla.org/mozilla-central/rev/9646898394f0
Attachment #392150 -
Attachment description: (Av1) version_win.pl → (Av1) version_win.pl
[Checkin: Comment 2]
Assignee | ||
Comment 3•15 years ago
|
||
/modules/zlib/src/ChangeLog (View Hg log or Hg annotations) This is (third party) documentation only. /js/jsd/jsd1640.rc (View Hg log or Hg annotations) This is part of bug 479184. /toolkit/crashreporter/google-breakpad/src/google_breakpad/common/minidump_format.h * line 175 -- #define MD_VSFIXEDFILEINFO_FILE_OS__WINDOWS16 1 /* VOS__WINDOWS16 */ CR seems to like unused obsolete definition...
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Keywords: meta
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2b1
Assignee | ||
Comment 4•15 years ago
|
||
Fixes version_win.pl "Unknown option: bits".
Attachment #398115 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 5•15 years ago
|
||
Attachment #398116 -
Flags: review?(kairo)
Updated•15 years ago
|
Attachment #398116 -
Flags: review?(kairo) → review+
Comment 6•15 years ago
|
||
Comment on attachment 398115 [details] [diff] [review] (Bv1-MC) version.mk [Checkin: Comment 7 & 8] I was going to say that I hoped the Win64 guys didn't need that BITS stuff, but it only special-cased 16 bit anyway.
Attachment #398115 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 7•15 years ago
|
||
Comment on attachment 398115 [details] [diff] [review] (Bv1-MC) version.mk [Checkin: Comment 7 & 8] http://hg.mozilla.org/mozilla-central/rev/9eef7e8317a9
Attachment #398115 -
Attachment description: (Bv1-MC) version.mk → (Bv1-MC) version.mk
[Checkin: Comment 7]
Assignee | ||
Updated•15 years ago
|
status1.9.2:
--- → beta1-fixed
Target Milestone: mozilla1.9.2b1 → mozilla1.9.3a1
Assignee | ||
Comment 8•15 years ago
|
||
Comment on attachment 398115 [details] [diff] [review] (Bv1-MC) version.mk [Checkin: Comment 7 & 8] http://hg.mozilla.org/releases/mozilla-1.9.2/rev/8b71a0ce10a8
Attachment #398115 -
Attachment description: (Bv1-MC) version.mk
[Checkin: Comment 7] → (Bv1-MC) version.mk
[Checkin: Comment 7 & 8]
Assignee | ||
Comment 10•15 years ago
|
||
Cv1-CC, but supporting both 1.9.1 and 1.9.2+. (I initially thought I would land m-c part to m-1.9.1 too, but no.) Looking for approval too.
Attachment #398116 -
Attachment is obsolete: true
Attachment #401218 -
Flags: review?(kairo)
Comment 11•15 years ago
|
||
Comment on attachment 401218 [details] [diff] [review] (Cv1a-CC) version.mk [Checkin: Comment 13] you need to ask Standard8 for approval, as he intersects the SeaMonkey and Thunderbird teams ;-)
Attachment #401218 -
Flags: review?(kairo) → review+
Comment 12•15 years ago
|
||
Comment on attachment 401218 [details] [diff] [review] (Cv1a-CC) version.mk [Checkin: Comment 13] a=Standard8
Updated•15 years ago
|
Keywords: verified1.9.2
Assignee | ||
Comment 13•15 years ago
|
||
Comment on attachment 401218 [details] [diff] [review] (Cv1a-CC) version.mk [Checkin: Comment 13] http://hg.mozilla.org/comm-central/rev/f6bb11efe102
Attachment #401218 -
Attachment description: (Cv1a-CC) version.mk → (Cv1a-CC) version.mk
[Checkin: Comment 13]
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•