507947 - NSRectFill fails when drawRect isn't on the stack

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

Attachment: v1: replace NSRectFill with CGContextFillRect

We use NSRectFill in several places in native theme rendering, for example when drawing toolbars. However, I noticed that this doesn't work when drawing with Canvas.drawWindow: Toolbars never seem to make it into the Ctrl+Tab previews, for example. Instead, sometimes I've noticed grey lines or boxes at the bottom of the window, which has also been reported here: https://www.mozdev.org/bugs/show_bug.cgi?id=21200

So what seems to happen is that when we're not drawing inside drawRect, i.e. when [NSView focusView] is nil, NSRectFill instead draws into the next best window, preferable in a flipped way (on the bottom instead of at the top of the window, for example).

I don't know why this happens, but I found out that CGFillRect does not do these things. So I'm replacing all calls to NSRectFill with CGFillRect, factored out into a DrawNativeGreyColorInRect in nsNativeThemeColors.h.
The other change I'm making is to treat the window always as active when there's no focusView because I think it makes more sense for tab previews.

Comment 2

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/9d37b381e2ae

Comment 3

[Markus Stange [:mstange]]

Attachment: simple reftest

Before this patch, -moz-appearance: toolbar didn't draw anything when used inside canvas.drawWindow, so this should be enough.

Comment 4

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/be99b00e43f6

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 392191 [details] [diff] [review]
v1: replace NSRectFill with CGContextFillRect

fixes the spurious appearance of grey boxes on a page with certain combinations of extensions (e.g. FireFTP + Ctrl-Tab), very low risk, has test

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 392191 [details] [diff] [review]
v1: replace NSRectFill with CGContextFillRect

Approved for 1.9.1.4, a=dveditz for release-drivers

Comment 7

[Markus Stange [:mstange]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/97a8e3170b87

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on 1.9.2 and 1.9.1 based on check-ins and passing reftests.