gfx.downloadable_fonts.enabled should be live apply

RESOLVED FIXED

Status

()

Core
Graphics
--
enhancement
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
prefs should really be live apply.... i'm not quite sure how to flush font face rules from existing pages, but we can at least let users influence new pages.
(Assignee)

Comment 1

8 years ago
Created attachment 392224 [details] [diff] [review]
proposal
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #392224 - Flags: review?(jdaggett)
Comment on attachment 392224 [details] [diff] [review]
proposal

A couple drive-by comments....

>+#define GFX_DOWNLOADABLE_FONTS_ENABLED "gfx.downloadable_fonts.enabled"

How about making this a static const char* as well, like the CMS prefs?

>+    } else if (pref.EqualsLiteral(GFX_DOWNLOADABLE_FONTS_ENABLED)) {
>+        if (gPlatform)
>+            gPlatform->DownloadableFontsEnabled();

I don't see how just calling DownloadableFontsEnabled() here will cause the change to be noticed. Once sDownloadableFontsInitialized has been set to TRUE, that function becomes a no-op. Were you intending to reset that flag to FALSE here? (And then there'd be no need to actually call the function.)

Comment 3

7 years ago
Comment on attachment 392224 [details] [diff] [review]
proposal

The value of 'sDownloadableFontsInitialized' needs to be reset in the ::Observe method I think.

The patch on bug 504698 should resolve the lack of live apply for this pref.
Attachment #392224 - Flags: review?(jdaggett) → review-

Comment 4

6 years ago
This works as expected in current Aurora.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.