Last Comment Bug 507988 - gfx.downloadable_fonts.enabled should be live apply
: gfx.downloadable_fonts.enabled should be live apply
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All All
-- enhancement (vote)
: ---
Assigned To: timeless
: Milan Sreckovic [:milan]
Depends on:
  Show dependency treegraph
Reported: 2009-08-03 02:30 PDT by timeless
Modified: 2011-10-07 10:55 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

proposal (4.48 KB, patch)
2009-08-03 02:32 PDT, timeless
jd.bugzilla: review-
Details | Diff | Splinter Review

Description User image timeless 2009-08-03 02:30:35 PDT
prefs should really be live apply.... i'm not quite sure how to flush font face rules from existing pages, but we can at least let users influence new pages.
Comment 1 User image timeless 2009-08-03 02:32:29 PDT
Created attachment 392224 [details] [diff] [review]
Comment 2 User image Jonathan Kew (:jfkthame) 2010-03-09 06:04:01 PST
Comment on attachment 392224 [details] [diff] [review]

A couple drive-by comments....

>+#define GFX_DOWNLOADABLE_FONTS_ENABLED "gfx.downloadable_fonts.enabled"

How about making this a static const char* as well, like the CMS prefs?

>+    } else if (pref.EqualsLiteral(GFX_DOWNLOADABLE_FONTS_ENABLED)) {
>+        if (gPlatform)
>+            gPlatform->DownloadableFontsEnabled();

I don't see how just calling DownloadableFontsEnabled() here will cause the change to be noticed. Once sDownloadableFontsInitialized has been set to TRUE, that function becomes a no-op. Were you intending to reset that flag to FALSE here? (And then there'd be no need to actually call the function.)
Comment 3 User image John Daggett (:jtd) 2010-05-13 02:27:11 PDT
Comment on attachment 392224 [details] [diff] [review]

The value of 'sDownloadableFontsInitialized' needs to be reset in the ::Observe method I think.

The patch on bug 504698 should resolve the lack of live apply for this pref.
Comment 4 User image Chris Lord [:cwiiis] 2011-10-07 10:55:23 PDT
This works as expected in current Aurora.

Note You need to log in before you can comment on or make changes to this bug.