Closed Bug 508000 Opened 15 years ago Closed 15 years ago

Search bar & find bar value before switching into Private Browsing mode is not restored after leaving PB mode

Categories

(Firefox :: Private Browsing, defect)

Product:
Firefox
Component:
Private Browsing
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.6b1
Tracking Flags:
Tracking Status
status1.9.1 --- ?

People

(Reporter: spam.Jason.Cook599, Assigned: ehsan.akhgari)

References

Details

(Keywords: regression)

Attachments

(1 file)

Patch (v1)
6.43 KB, patch
mconnor
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1 GTB5 (.NET CLR 3.5.30729) AutoPager/0.5.2.2 (http://www.teesoft.info/)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1 GTB5 (.NET CLR 3.5.30729) AutoPager/0.5.2.2 (http://www.teesoft.info/)

If I make a search before I enter Private Browsing it clears when I exit Private Browsing.

Reproducible: Always

Steps to Reproduce:
1.Make a search from the search box
2.Enter Private Browsing
3.Exit Private Browsing
Actual Results:  
Previous search result is gone.

Expected Results:  
Should have remember previous search. It would be useful if even if you made a search in Private Browsing it would remeber you search before Private Prowsing (as is done with tabs).
So we really don't want to display the former search bar value after leaving PB mode?
Blocks: 463202
Status: UNCONFIRMED → NEW
Component: Search → Private Browsing
Ever confirmed: true
Keywords: regression
OS: Windows XP → All
QA Contact: search → private.browsing
Hardware: x86 → All
Summary: Clears Search When Exit Private Browsing → Search bar value before switching into Private Browsing mode is not restored after leaving PB mode
Version: unspecified → 3.5 Branch
(In reply to comment #2)
> So we really don't want to display the former search bar value after leaving PB
> mode?

It seems that way. I think that we should either restore all of the setting (tabs, search history, ect.) from before Private Browsing or restore none of it.
(In reply to comment #2)
> So we really don't want to display the former search bar value after leaving PB
> mode?

No, we do want to restore that, as well as the findbar contents.
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Summary: Search bar value before switching into Private Browsing mode is not restored after leaving PB mode → Search bar & find bar value before switching into Private Browsing mode is not restored after leaving PB mode
Attached patch Patch (v1) — — Splinter Review 

        Attachment #392907 -
        Flags: review?(mconnor)

    
  
Whiteboard: [needs r=mconnor]

    
    

    
  
Comment on attachment 392907 [details] [diff] [review]
Patch (v1)

looks good.

        Attachment #392907 -
        Flags: review?(mconnor) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/ec75a15ed318
Status: ASSIGNED → RESOLVED
Closed: 15 years ago

          status1.9.1:
          --- → ?
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs r=mconnor]
Target Milestone: --- → Firefox 3.6b1
Version: 3.5 Branch → Trunk

    
    

    
  
Verified fixed with builds on OS X and Windows like Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a2pre) Gecko/20090810 Minefield/3.6a2pre ID:20090810031114
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: