Closed
Bug 508021
Opened 15 years ago
Closed 15 years ago
nsNPAPIPluginInstance::Print does not need to null check mCallbacks
Categories
(Core Graveyard :: Plug-ins, enhancement)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file)
|
2.01 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
* modules/plugin/base/src/nsNPAPIPlugin.cpp
o line 588 -- new nsNPAPIPluginInstance(&fCallbacks, fLibrary);
870 nsNPAPIPluginInstance::nsNPAPIPluginInstance(NPPluginFuncs* callbacks,
872 : mCallbacks(callbacks),
890 NS_ASSERTION(mCallbacks != NULL, "null callbacks");
1296 NS_IMETHODIMP nsNPAPIPluginInstance::Print(nsPluginPrint* platformPrint)
1307 if (mCallbacks) {
|
||
Updated•15 years ago
|
Attachment #392480 -
Flags: superreview+
Attachment #392480 -
Flags: review?(jst)
Attachment #392480 -
Flags: review+
http://hg.mozilla.org/mozilla-central/rev/dd99a2aeb8b2
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•