nsNPAPIPluginInstance::Print does not need to null check mCallbacks

RESOLVED FIXED

Status

()

Core
Plug-ins
--
enhancement
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({coverity})

Trunk
coverity
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
* modules/plugin/base/src/nsNPAPIPlugin.cpp
          o line 588 -- new nsNPAPIPluginInstance(&fCallbacks, fLibrary); 

870 nsNPAPIPluginInstance::nsNPAPIPluginInstance(NPPluginFuncs* callbacks,
872   : mCallbacks(callbacks),
890   NS_ASSERTION(mCallbacks != NULL, "null callbacks");

1296 NS_IMETHODIMP nsNPAPIPluginInstance::Print(nsPluginPrint* platformPrint)
1307   if (mCallbacks) {
(Assignee)

Updated

8 years ago
Depends on: 113264
(Assignee)

Comment 1

8 years ago
Created attachment 392480 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #392480 - Flags: review?(jst)

Updated

8 years ago
Attachment #392480 - Flags: superreview+
Attachment #392480 - Flags: review?(jst)
Attachment #392480 - Flags: review+
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/dd99a2aeb8b2
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.