Closed Bug 508021 Opened 11 years ago Closed 11 years ago

nsNPAPIPluginInstance::Print does not need to null check mCallbacks

Categories

(Core :: Plug-ins, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file)

* modules/plugin/base/src/nsNPAPIPlugin.cpp
          o line 588 -- new nsNPAPIPluginInstance(&fCallbacks, fLibrary); 

870 nsNPAPIPluginInstance::nsNPAPIPluginInstance(NPPluginFuncs* callbacks,
872   : mCallbacks(callbacks),
890   NS_ASSERTION(mCallbacks != NULL, "null callbacks");

1296 NS_IMETHODIMP nsNPAPIPluginInstance::Print(nsPluginPrint* platformPrint)
1307   if (mCallbacks) {
Depends on: 113264
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #392480 - Flags: review?(jst)
Attachment #392480 - Flags: superreview+
Attachment #392480 - Flags: review?(jst)
Attachment #392480 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/dd99a2aeb8b2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.