50811 - Plugins need way to access HTTP response headers on GET/POST

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[edburns]

Currently there is no way for plugins to access the response headers for HTTP 
GET or POST requests.

Comment 1

[edburns]

accept.

Comment 2

[edburns]

This bug fix was suggested by Stanley Ho <[e-mail]>.  

Stanley proposed we overload the meaning of the nsIPluginStreamListener
argument to nsIPluginManager::{GetURL,PostURL}() so that it also may
implement an interface for reading headers.  Thus, the browser could QI
the plugin's nsIPluginStreamListener instance to this headers reading
interface and send the plugin the headers from the response.

I have implemented Stanley's above proposal.  I have defined a new
interface, nsIPluginHTTPHeaderListener.idl with one method:

  /**

   * Called for each HTTP Response header.

   * NOTE: You must copy the values of the params.  

   */

  void newResponseHeader(in string headerName, in string headerValue);

To affect this fix, I have added a new private method

nsPluginStreamListenerPeer::
ReadHeadersFromChannelAndPostToListener(nsIHTTPChannel *httpChannel,
                                        nsIPluginHTTPHeaderListener *listener)

Then, modified nsPluginStreamListenerPeer::OnDataAvailable() to call
this method BEFORE reading the content data.  However, this fix makes
two important assumptions I would like to check out:

   * Assumption

   * By the time nsPluginStreamListenerPeer::OnDataAvailable() gets
   * called, all the headers have been read.

       * Assumption: 

       * The return value from nsIHTTPHeader->{GetFieldName,GetValue}()
       * must be freed.

The following files are included in this fix:

A modules/plugin/public/nsIPluginHTTPHeaderListener.idl
M modules/plugin/nglsrc/nsPluginHostImpl.cpp

Attachments to follow.

Comment 3

[edburns]

Attachment: cvs diff -u of fix for this bug, first iteration.

Comment 4

[edburns]

Attachment: cvs diff of fix for this bug, first iteration

Comment 5

[edburns]

Attachment: tar.gz of all the files (including new ones) of the fix for this bug, first iteration.

Comment 6

[ekrock's old account (dead)]

Increasing priority to P2 as this is high profile functionality (functional 
completeness and usability of plug-in API for plug-in partners) and high profile 
backward compatibility (determines whether plug-in vendors will be able to 
upgrade their plug-ins to provide equivalent functionality on N6 as they did on 
N4). Ed, want to accept this as [nsbeta3+]? Mark it as so if you think you can 
fix this in time. P2s can be checked in with mozilla reviewer approval through 
9/21.

Comment 7

[edburns]

Fix checked in.

Comment 8

[edburns]

*** Bug 52973 has been marked as a duplicate of this bug. ***

Comment 9

[edburns]

Please see bug 52963.

Comment 10

[edburns]

Fix checked in.

Comment 11

[shrirang khanzode]

spam: marking verified.