508130 - [as] install.rdf doesn't contain proper information for Assamese language packs

Status: RESOLVED FIXED

(Mozilla Localizations :: as / Assamese, defect)

Description

[Matěj Cepl]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.1.1) Gecko/20090717 Fedora/3.5.1-3.fc11 Firefox/3.5.1
Build Identifier: 

(originally filed as https://bugzilla.redhat.com/show_bug.cgi?id=513708)


Reproducible: Always

Steps to Reproduce:
1. Go to Addons->Languages
2.
3.
Actual Results:  
the "English (US)" language pack is listed more than once for some reason.

Expected Results:  
every language is there just once

Actually, it's just that the contributors didn't change the name string from
whatever they used for a template.

/usr/lib/firefox-3.5.1/extensions/[e-mail]/install.rdf

<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
     xmlns:em="http://www.mozilla.org/2004/em-rdf#">
  <Description about="urn:mozilla:install-manifest"
               em:id="[e-mail]"
               em:name="English (US) Language Pack"
               em:version="3.5.1"
               em:type="8"
               em:creator="mozilla.org">
    <em:contributor>Amitakhya Phukan
&lt;[e-mail]&gt;</em:contributor>
....


/usr/lib/firefox-3.5.1/extensions/[e-mail]/install.rdf

<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
     xmlns:em="http://www.mozilla.org/2004/em-rdf#">
  <Description about="urn:mozilla:install-manifest"
               em:id="[e-mail]"
               em:name="English (US) Language Pack"
               em:version="3.5.1"
               em:type="8"
               em:creator="mozilla.org">
....

Definitely needs an upstream fix.  Could be patched meanwhile.

Comment 1

[Matěj Cepl]

actually this is a mistake ... duplicate of bug 504288

Comment 2

[Axel Hecht [:Pike]]

Let's have one bug for Oriya and one for Assamese. Moving this over to Assamese.

Amitakhya, please fix toolkit/defines.inc?

Comment 3

[Axel Hecht [:Pike]]

Oops, Amitakhya already did. http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/as/rev/cf8a573950c5.

Leaving this bug open until we have a fix on l10n-central, and a signed-off version of this on 1.9.1 minor updates.

Amitakhya, it'd be a good time to start updating the l10n-central repo with the contents of l10n-mozilla-1.9.1, I guess? I'll hop on on irc later today, then we chat about that.

Comment 4

[Matěj Cepl]

Just to note, that I haven't checked any other langpacks ... these were the ones I checked.

Comment 5

[Matěj Cepl]

I have made this test:

bradford:tmp$ for lang in af ar as be bg bn-BD bn-IN ca cs cy da de el en-GB eo es-AR es-CL es-ES es-MX et eu fa fi fr fy-NL ga-IE gl gu-IN he hi-IN hr hu id is it ja ka kk kn ko ku lt lv mk ml mn mr nb-NO nl nn-NO oc or pa-IN pl pt-BR pt-PT rm ro ru si sk sl sq sr sv-SE ta-LK ta te th tr uk vi zh-CN zh-TW ; do TMPFILE=$(mktemp /tmp/lang.XXXXXX) ; curl -s -o $TMPFILE http://releases.mozilla.org/pub/mozilla.org/firefox/releases/3.5.2/linux-i686/xpi/$lang.xpi ; if (unzip -p $TMPFILE install.rdf |grep 'em:name="English' >/dev/null 2>&1) ; then echo "$lang.xpi is English" ; fi; rm $TMPFILE ; done 
as.xpi is English
en-GB.xpi is English
or.xpi is English
bradford:tmp$ 

So it sems as.xpi and or.xpi are the only ones broken.

Comment 6

[Axel Hecht [:Pike]]

Wow, thanks.

For future reference, what's currently on the default branch can be checked on mxr. That doesn't really say whether it's in the released bits, though. A query for this problem would be http://mxr.mozilla.org/l10n-mozilla1.9.1/search?string=MOZ_LANG_TITLE&find=toolkit/defines.inc, where you can than just search in the page for English. Doesn't show 'as' anymore, which is because it's fixed on default, but not released in that revision.

Comment 7

[Axel Hecht [:Pike]]

FIXED on 1.9.1 and 1.9.2, resolving FIXED.