Need to fix some minor L10n problems

VERIFIED FIXED in 5.0.9

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: clouserw, Assigned: clouserw)

Tracking

unspecified
5.0.9

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

9 years ago
line 441 of the validation component is concatenating strings:

"The file contains a global %s" -- we can't have that.  This should be 3 strings, one for functions, variables, and constants.

I've removed the strings from the .po for now, so we can grab this in the next milestone.
Here's another one:

#. %1$s is a string, the type of add-on.  Example: extension, dictionary, theme
#. %2$s is a filename.  Example: windows.com
#: controllers/components/validation.php:974
msgid "devcp_error_missing_file"
msgstr "The %1$s was missing a required file: %2$s"

-- the assumption that extension, dictionary and theme all have the same gender in all languages is bold. :)
(Assignee)

Comment 2

9 years ago
(In reply to comment #1)
> Here's another one:
> 
> #. %1$s is a string, the type of add-on.  Example: extension, dictionary, theme
> #. %2$s is a filename.  Example: windows.com
> #: controllers/components/validation.php:974
> msgid "devcp_error_missing_file"
> msgstr "The %1$s was missing a required file: %2$s"
> 
> -- the assumption that extension, dictionary and theme all have the same gender
> in all languages is bold. :)

Yeah, I almost changed that to "add-on" and got rid of the substitution.  Guess I should have.

Comment 3

9 years ago
Created attachment 392535 [details] [diff] [review]
L10n fixes
Attachment #392535 - Flags: review?(clouserw)
(Assignee)

Updated

9 years ago
Attachment #392535 - Flags: review?(clouserw) → review-
(Assignee)

Comment 4

9 years ago
Comment on attachment 392535 [details] [diff] [review]
L10n fixes

There is more changing than just l10n in this patch

Comment 5

9 years ago
Created attachment 392603 [details] [diff] [review]
Patch without extra changes
Attachment #392535 - Attachment is obsolete: true
Attachment #392603 - Flags: review?(clouserw)
(Assignee)

Comment 6

9 years ago
Comment on attachment 392603 [details] [diff] [review]
Patch without extra changes

Since we can't commit this right away I'm r-'ing it so we don't lose track:  the very first line is changing a regex pattern which is not l10n.
Attachment #392603 - Flags: review?(clouserw) → review-

Comment 7

9 years ago
Actually, that is just the test result which I noticed needed to change when I ran the unit tests.  If not part of this patch, is there a good place to land this?

Comment 8

9 years ago
Created attachment 393237 [details] [diff] [review]
Patch with regex changes removed

This does contain a few unit test updates to match new strings
Attachment #392603 - Attachment is obsolete: true
Attachment #393237 - Flags: review?(clouserw)
(Assignee)

Updated

9 years ago
Attachment #393237 - Flags: review?(clouserw) → review+
(Assignee)

Comment 9

9 years ago
Comment on attachment 393237 [details] [diff] [review]
Patch with regex changes removed

Go for it and assign to me when you're done for the L10n changes

Comment 10

9 years ago
Fixed in r48792, assigning to you for L10n changes
Assignee: rjbuild1088 → clouserw
(Assignee)

Comment 11

9 years ago
r48799
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Fred, would you be so kind as to verify this?  Thanks!
Certainly. Yes, I saw this being fixed. Thanks!
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.