[Buildbot] Should compile and run acceptance suite with -AS3

RESOLVED FIXED in Q3 11 - Serrano


10 years ago
9 years ago


(Reporter: brbaker, Assigned: dschaffe)


Q3 11 - Serrano
Dependency tree / graph
Bug Flags:
in-testsuite +
flashplayer-qrb +
flashplayer-triage +


(Whiteboard: buildbot)


(5 attachments, 2 obsolete attachments)

Should have deep testing for compiling and running the acceptance suite with -AS3. There are currently 173 known tests that do NOT pass when compiled with the AS3 class based object model (tests manipulate the prototype chain).

These failures should be accounted for in the testconfig and we should compile and test with the -AS3
Flags: in-testsuite?
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Should do runs with and w/o -AS3
Assignee: nobody → dschaffe
Flags: flashplayer-qrb? → flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → flash10.1
moving target to future since the bug is not required for 10.1 release.
Target Milestone: flash10.1 → Future
I think this is being enabled in bug 523863, check patch https://bug523863.bugzilla.mozilla.org/attachment.cgi?id=408155
Patch mentioned above only adds -AS3 flag to performance suite when -optimize is specified.
QRB: re-target
Component: Tools → Build Config
Flags: flashplayer-qrb+ → flashplayer-qrb?
QA Contact: tools → build-config
Whiteboard: buildbot
Duplicate of this bug: 575322
Target Milestone: Future → flash10.2
Depends on: 602995
OS: Windows XP → All
runtests.py: code cleanup and slight rearrangement - no change in functionality

Added --addtoconfig command line switch that adds the given string to the generated config (in between os and vm args)

Added ability to specify negative args in --ascargs.  e.g: --ascargs=-no-AS3 will remove -AS3 from any compiler args if specified in an .asc_args file.
Attachment #482599 - Flags: review?(brbaker)
1. Compile all tests (expect ecma3 & spidermonkey) with -AS3 by using dir.asc_args files.
2. Add as3Enabled():Boolean to detect whether test was compiled with -AS3 to shell.as
3. Update as3/Vector/sort* to check for correct error depending on how it was compiled.
4. Update RuntimeErrors/Error1034TypeCoercionFailed to use code that consistently throws a 1034
5. Update testconfig for vector/map failures w/ -AS3
Attachment #482603 - Flags: review?(brbaker)
Buildbot changes to run -ES in deep and to run -ES in codecoverage
Attachment #482608 - Flags: review?(brbaker)
Updated buildbot patch based on brbaker feedback
Attachment #482608 - Attachment is obsolete: true
Attachment #482608 - Flags: review?(brbaker)
Attachment #482599 - Flags: review?(brbaker) → review+
Comment on attachment 482603 [details] [diff] [review]
update tests to run with -AS3

Reviewed with Brent over the phone - got the verbal r+ from him.
Attachment #482603 - Flags: review?(brbaker) → review+
Pushed to redux:
Closed: 9 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Flags: in-testsuite+
Flags: flashplayer-qrb?
Flags: flashplayer-qrb+
Resolution: FIXED → ---
All the ecma3 tests now run with no error when compiled with -AS3.  Note that the ecma3/dir.asc_args has been removed so that we compile ecma3 with -AS3 by default.  The dir is tested in -ES mode in the deep phase (already present).
Attachment #485456 - Flags: review?(brbaker)
Comment on attachment 485456 [details] [diff] [review]
Update ecma3 tests to run with -AS3

Can you type the as3Enabled var in the shell.as or is that going to cause issues trying to run -ES? 

- Scanned through the large patch [OK]
- Rebuilt locally                 [OK]
- Ran an acceptance pass          [FAIL]

When I recompiled all of the tests the following testcases failed with your patch, if I revert your change and rebuild the testcases pass:

as3/Definitions/Packages/IdentifierPackageNames.abc : captured output: ReferenceError: Error #1065
as3/Vector/sortInitializers.abc : captured output: Vector.sort(comparefn) | TypeError: Error #1006
as3/Vector/sort.abc : captured output: Vector.sort(comparefn) | TypeError: Error #1006

Please run patch through the sandbox for a sanity check to get all builds.
Attachment #485456 - Flags: review?(brbaker) → review-
Updated patch that addresses comments.  Ran in sandbox and only had ppc64 jit issues which have been set to expectedfail in testconfig (Bug 608130 and Bug 608132).
Attachment #485456 - Attachment is obsolete: true
Attachment #486780 - Flags: review?(brbaker)
Comment on attachment 486780 [details] [diff] [review]
Update ecma3 tests to run with -AS3

I am going to remove the review request until it is understood what this change will do to the ecma3 suite with regards to the ability to run all of the ecma3 tests through eval() (bug #608474)
Attachment #486780 - Flags: review?(brbaker)
Blocks: 608474
Attachment 486780 [details] [diff] does not add any as3 only constructs.  I would like to land this patch and we can then work on getting the ecma3 dir prepped for an eval run.
ecma3 patch pushed:

Closed: 9 years ago9 years ago
Resolution: --- → FIXED
changeset: 5917:3dbacc7ffe77
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 508316: make sure to grab new precompiled test media after running an acceptance pass with -ES. (r=brbaker)

You need to log in before you can comment on or make changes to this bug.