Closed Bug 508371 Opened 13 years ago Closed 13 years ago

gloda indexer's naive logging is inefficient

Categories

(MailNews Core :: Database, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b4

People

(Reporter: asuth, Assigned: asuth)

Details

Attachments

(4 files)

Performance investigation has revealed some inefficiencies in gloda indexing related to logging.  The blog post (which does not discuss the inefficiency, but has pretty pictures that express it if you are psychic) for the interested is:

http://www.visophyte.org/blog/2009/08/03/using-vmware-recordreplay-and-vprobes-for-low-time-distortion-performance-profiling/

I am attaching the actual that improves our performance right now.  On my system, the patch nets us approximately a 30% performance improvement.

I will also attach the patches that provide a simple indexing performance benchmark, as well as support for that benchmark.
Attachment #392570 - Flags: review?(bienvenu)
Assignee: nobody → bugmail
Status: NEW → ASSIGNED
One thing to note about the performance fix is that we are smarter about what we set the logging level as for the root gloda logger.  Previously we were setting it to all which would defeat the optimization of the patch because we would always think we are logging at a debug level (or higher).
Attachment #392570 - Flags: review?(bienvenu) → review+
pushed: http://hg.mozilla.org/comm-central/rev/134486bf6eac
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b4
You need to log in before you can comment on or make changes to this bug.