508378 - Gloda needs to recover better from 'bad messages'

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[David Ascher (:davida)]

STRs:

1) do a gloda search to find a bunch of messages, including some in a shared thread 
2) tweak columns to show thread column
3) hit the thread column header to toggle threading mode

--> empty or partially empty results.

The console shows

Error: hdr is null
Source File: file:///Applications/Shredder.app/Contents/MacOS/modules/gloda/dbview.js
Line: 164

  reportResults: function(aItems) {
    for each (let [, item] in Iterator(aItems)) {
      let hdr = item.folderMessage;
-->      this.searchListener.onSearchHit(hdr, hdr.folder);
    }
  },  

which asuth says means that i have some bad message.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

I added a header guard on the branch that has since landed, a null access will no longer occur.  Gloda thinking a message that it can't get to exists is another issue and I think covered sufficiently by existing bugs.