Closed Bug 508526 Opened 15 years ago Closed 15 years ago

Make gDownloadLastDir smarter

Categories

(Firefox :: Private Browsing, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.7a1
Tracking Status
status1.9.2 --- wontfix
status1.9.1 --- wontfix

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Followup from bug 499733 comment 11.

The gDownloadLastDir object in toolkit needs to be smarter, so that it saves the nsIFile as either a pref value or an in-memory value based on the current private browsing mode.
Attached patch Patch (v1)Splinter Review
Attachment #395032 - Flags: review?(mconnor)
Whiteboard: [needs r=mconnor]
Comment on attachment 395032 [details] [diff] [review]
Patch (v1)

Looks good, thanks.
Attachment #395032 - Flags: review?(mconnor) → review+
http://hg.mozilla.org/mozilla-central/rev/35cb659d031c
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs r=mconnor]
Target Milestone: --- → Firefox 3.7a1
Whiteboard: [not needed for 1.9.2]
The developer docs for this module should be similar to that of bug 499733.
Keywords: dev-doc-needed
To what does "[not needed for 1.9.2]" refer in the whiteboard here?
(In reply to comment #5)
> To what does "[not needed for 1.9.2]" refer in the whiteboard here?

It means that this patch is not important enough to take for 1.9.2.  That was before the status1.9.2 flag.  :-)
Whiteboard: [not needed for 1.9.2]
Whiteboard: [doc-waiting-1.9.3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: