Make gDownloadLastDir smarter

RESOLVED FIXED in Firefox 3.7a1

Status

()

Firefox
Private Browsing
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

({dev-doc-complete})

Trunk
Firefox 3.7a1
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(status1.9.2 wontfix, status1.9.1 wontfix)

Details

Attachments

(1 attachment)

Followup from bug 499733 comment 11.

The gDownloadLastDir object in toolkit needs to be smarter, so that it saves the nsIFile as either a pref value or an in-memory value based on the current private browsing mode.
Created attachment 395032 [details] [diff] [review]
Patch (v1)
Attachment #395032 - Flags: review?(mconnor)
Whiteboard: [needs r=mconnor]
Comment on attachment 395032 [details] [diff] [review]
Patch (v1)

Looks good, thanks.
Attachment #395032 - Flags: review?(mconnor) → review+
http://hg.mozilla.org/mozilla-central/rev/35cb659d031c
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs r=mconnor]
Target Milestone: --- → Firefox 3.7a1
Whiteboard: [not needed for 1.9.2]
status1.9.1: --- → wontfix
The developer docs for this module should be similar to that of bug 499733.
Keywords: dev-doc-needed
To what does "[not needed for 1.9.2]" refer in the whiteboard here?
(In reply to comment #5)
> To what does "[not needed for 1.9.2]" refer in the whiteboard here?

It means that this patch is not important enough to take for 1.9.2.  That was before the status1.9.2 flag.  :-)
status1.9.2: --- → wontfix
Whiteboard: [not needed for 1.9.2]
Whiteboard: [doc-waiting-1.9.3]
Documented:

https://developer.mozilla.org/en/JavaScript/Code_modules/DownloadLastDir.jsm

Added to the list here:

https://developer.mozilla.org/en/Firefox_4_for_developers#JavaScript_code_modules

And here:

https://developer.mozilla.org/en/JavaScript/Code_modules
Keywords: dev-doc-needed → dev-doc-complete
Whiteboard: [doc-waiting-1.9.3]
You need to log in before you can comment on or make changes to this bug.