Closed
Bug 508541
Opened 15 years ago
Closed 10 years ago
flag notifications depend on CGI to get the bug comment
Categories
(Bugzilla :: Email Notifications, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.0
People
(Reporter: LpSolit, Assigned: mail)
References
Details
(Whiteboard: [blocker will fix])
request/email.txt.tmpl calls Bugzilla.cgi.param("comment") to get the comment added while editing flag requests. This makes it impossible to use correctly with e.g. WebServices as the comment would not be accessible via CGI, and so the flagmail would not have the comment in it. We should find another CGI-independent way to get the comment.
Comment 1•15 years ago
|
||
You might be interested in how I got the comments for my traceparser extension. See the bug_update subroutine here: http://bzr.everythingsolved.com/bugzilla-traceparser/trunk/annotate/head%3A/lib/TraceParser/Hooks.pm
Updated•14 years ago
|
Target Milestone: Bugzilla 3.6 → Bugzilla 3.8
Updated•14 years ago
|
Target Milestone: Bugzilla 4.0 → Bugzilla 5.0
Reporter | ||
Comment 2•12 years ago
|
||
We are going to branch for Bugzilla 4.4 next week and this bug is either too invasive to be accepted for 4.4 at this point or shows no recent activity. The target milestone is reset and will be set again *only* when a patch is attached and approved. I ask the assignee to reassign the bug to the default assignee if you don't plan to work on this bug in the near future, to make it clearer which bugs should be fixed by someone else.
Target Milestone: Bugzilla 4.4 → ---
Comment 4•10 years ago
|
||
Dave, as I understand it this bug means that switching tools from the BzAPI proxy to the new shim created in bug 880669 will regress the bugmail notifications sent out for attachments. If so, that's quite a regression given the proliferation of usage of bzexport. Would you/glob mind taking a look at this? :-)
Blocks: 880669
Flags: needinfo?(dkl)
Comment 5•10 years ago
|
||
(In reply to Max Kanat-Alexander from comment #1) > You might be interested in how I got the comments for my traceparser > extension. See the bug_update subroutine here: > http://bzr.everythingsolved.com/bugzilla-traceparser/trunk/annotate/head%3A/ > lib/TraceParser/Hooks.pm Of course this link is no longer available :( This will not be trivial as the way Bug.add_attachment and Bug.update_attachment is currently written the flags are updated and notifications mailed before we add the comment to the longdescs table so it is not possible to pull from there. We can check for Bugzilla->input_params->{comment} in Bug::Flag::notify but that is kind of a hack. Will look for a more universal solution. dkl
Assignee: email-notifications → dkl
Status: NEW → ASSIGNED
Flags: needinfo?(dkl)
Target Milestone: --- → Bugzilla 5.0
Assignee | ||
Updated•10 years ago
|
Assignee: dkl → email-notifications
Status: ASSIGNED → NEW
Depends on: CVE-2014-1571
Whiteboard: [blocker will fix]
Updated•10 years ago
|
Target Milestone: Bugzilla 5.0 → ---
Reporter | ||
Comment 6•10 years ago
|
||
Fixed by bug 1064140.
Assignee: email-notifications → sgreen
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 4.0
You need to log in
before you can comment on or make changes to this bug.
Description
•