508547 - delete statements should evaluate functions before attempting to delete the result

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[rspeyer]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_7; en-US) AppleWebKit/532.0 (KHTML, like Gecko) Chrome/3.0.196 Safari/532.0
Build Identifier: Rhino 1.7 release 2 2009 03 22

As per spec 11.4.1, step 1.

Reproducible: Always

Actual Results:  
js> delete (function() { print('hi') })()
true
js>

Expected Results:  
js> delete (function() { print('hi') })()
hi
true
js>

Comment 1

[rspeyer]

Attachment: modifications to parse tree rewriting which prevented functions from being evalutated before a delete

Comment 2

[Norris Boyd]

Checking in src/org/mozilla/javascript/IRFactory.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/IRFactory.java,v  <--  IRFactory.java
new revision: 1.126; previous revision: 1.125
done

Comment 3

[Hannes Wallnoefer]

For the record, I generalized this patch for all types of delete operands in response to bug #726121.

https://github.com/mozilla/rhino/commit/9e3d434569218fc5ae2a14a0241582e7939956c9