508677 - Remove extension/python from mozilla-central

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

I've been working with Todd Whiteman (new PyXPCOM owner) to get the PyXPCOM code out of mozilla-central and into its own tree.

Today I imported pyxpcom from mozilla-central to the new repository:
http://hg.mozilla.org/pyxpcom/rev/6ffa3a7a6aee

And hooked up the build system by copying over the relevant bits from mozilla-central:
http://hg.mozilla.org/pyxpcom/rev/d17d29dc2184

I've tested this on Linux and it works as far as it could (there's a compile error in dom/ due to new methods on nsIScriptContext which need to be implemented by PyXPCOM). I'd like to remove extensions/pyxpcom from mozilla-central and the related configure machinery for it and make the new repo the official location of PyXPCOM.

Todd can you give module owner approval for this?

Comment 1

[Todd Whiteman]

How does one configure/build/test PyXPCOM from the hg sources once this changes?

I was thinking I'd perform a usual hg.mozilla checkout and then checkout the pyxpcom module into the "extensions/python" directory, configure/build with the "--enable-extensions=python" flag (which is still handled in the central Mozilla configure.in script)... in which case the additional "pyxpcom/configure.in" and "pyxpcom/aclocal.m4" are used for?

Comment 2

[Benjamin Smedberg]

Ah, no, you download or build the XULRunner SDK, and then do

../configure --with-libxul-sdk=/path/to/xulrunner-sdk

Comment 3

[Todd Whiteman]

Right - seems to work as expected, you have my approval for the changes.

I ran into some build issues with building against the SDK - nothing major - I made some notes below:

It does not work with the SDK (as the include path for mozilla-config.h does not get set correctly), but that can be fixed up later - worked around this by updating the path to mozilla-config.h.

The pyxpcom build still tries to use "nspr-config"... but it seems this is not part of the XulRunner 1.9.2 SDK - this does not seem to cause any problems whilst building - can be fixed later if necessary.

After that things started building as it should, though it ran into linkage errors - requiring me to add "-lnspr4 -lplc4" to the EXTRA_DSO_LDOPTS - can fix this later.

Finally I've gotten to the nsIScriptContext errors you were talking about.

Comment 4

[Benjamin Smedberg]

Hrm, if  you're building against a trunk (1.9.2) SDK mozilla-config.h should be in the right place, although I tested against a raw tree (xulrunner/dist) and not a packaged SDK. Feel free to file an SDK packaging bug about both of those issues if necessary.

Comment 5

[Benjamin Smedberg]

Attachment: Remove pyxpcom from mozilla-central, rev. 1

Comment 6

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/5479f683ebbc