Closed
Bug 508720
Opened 12 years ago
Closed 12 years ago
Remove less than 4 for GCC Version in Mac
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2b1
People
(Reporter: xfsunoles, Assigned: xfsunoles)
References
Details
Attachments
(1 file, 1 obsolete file)
5.23 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Occurring to the mac build requirement, GCC version less than 4 is unsupported in the Trunk and apple is never shipped it anymore.
Attachment #392854 -
Flags: review?(ted.mielczarek)
Updated•12 years ago
|
Attachment #392854 -
Flags: review?(ted.mielczarek) → review-
Comment 1•12 years ago
|
||
Comment on attachment 392854 [details] [diff] [review] Tell it so - if test "$GCC_VERSION_MAJOR" -lt "4" ; then I think you should keep this check, but AC_MSG_ERROR inside it, telling the user that they need a newer compiler.
Assignee | ||
Comment 2•12 years ago
|
||
I keep that check in and put AC_MSG_ERROR just like you ask.
Assignee: nobody → xfsunoles
Attachment #392854 -
Attachment is obsolete: true
Attachment #393280 -
Flags: review?(ted.mielczarek)
Comment 3•12 years ago
|
||
Comment on attachment 393280 [details] [diff] [review] Patch v2 [Checkin: Comment 4] Looks good, thanks. I don't know if we could make the error message clearer, but what you have is fine.
Attachment #393280 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 4•12 years ago
|
||
Comment on attachment 393280 [details] [diff] [review] Patch v2 [Checkin: Comment 4] http://hg.mozilla.org/mozilla-central/rev/e643303bec3e
Attachment #393280 -
Attachment description: Patch v2 → Patch v2
[Checkin: Comment 4]
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6b1
Updated•11 years ago
|
Product: Firefox → Core
QA Contact: build.config → build-config
Target Milestone: Firefox 3.6b1 → mozilla1.9.2b1
Updated•3 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•