Closed Bug 508720 Opened 13 years ago Closed 13 years ago

Remove less than 4 for GCC Version in Mac

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2b1

People

(Reporter: xfsunoles, Assigned: xfsunoles)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch v2 [Checkin: Comment 4]
5.23 KB, patch
ted
: review+
Details | Diff | Splinter Review
Attached patch Tell it so (obsolete) — — Splinter Review 
Occurring to the mac build requirement, GCC version less than 4 is unsupported in the Trunk and apple is never shipped it anymore.
Attachment #392854 - Flags: review?(ted.mielczarek)
Attachment #392854 - Flags: review?(ted.mielczarek) → review-
Comment on attachment 392854 [details] [diff] [review]
Tell it so

-  if test "$GCC_VERSION_MAJOR" -lt "4" ; then

I think you should keep this check, but AC_MSG_ERROR inside it, telling the user that they need a newer compiler.
I keep that check in and put AC_MSG_ERROR just like you ask.
Assignee: nobody → xfsunoles
Attachment #392854 - Attachment is obsolete: true
Attachment #393280 - Flags: review?(ted.mielczarek)
Comment on attachment 393280 [details] [diff] [review]
Patch v2
[Checkin: Comment 4]

Looks good, thanks. I don't know if we could make the error message clearer, but what you have is fine.
Attachment #393280 - Flags: review?(ted.mielczarek) → review+
Keywords: checkin-needed
Comment on attachment 393280 [details] [diff] [review]
Patch v2
[Checkin: Comment 4]


http://hg.mozilla.org/mozilla-central/rev/e643303bec3e
Attachment #393280 - Attachment description: Patch v2 → Patch v2 [Checkin: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6b1
Product: Firefox → Core
QA Contact: build.config → build-config
Target Milestone: Firefox 3.6b1 → mozilla1.9.2b1
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.