Cache Bugzilla::Status::BUG_STATE_OPEN

RESOLVED FIXED in Bugzilla 3.4

Status

()

Bugzilla
Bugzilla-General
--
enhancement
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

Bugzilla 3.4
Bug Flags:
approval +
approval3.4 +

Details

(Whiteboard: [es-gnome])

Attachments

(1 attachment)

v1
1.08 KB, patch
Frédéric Buclin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
I have some code that I'm running in an extension where most of the time is taken up by calling BUG_STATE_OPEN. Its return value should be cached.
(Assignee)

Comment 1

8 years ago
Created attachment 392868 [details] [diff] [review]
v1

Let me know if you think this is safe enough to backport to 3.4.
Assignee: general → mkanat
Status: NEW → ASSIGNED
Attachment #392868 - Flags: review?(LpSolit)

Comment 2

8 years ago
Comment on attachment 392868 [details] [diff] [review]
v1

Looks good to me. Should be a nice perf improvement. r=LpSolit
Attachment #392868 - Flags: review?(LpSolit) → review+

Comment 3

8 years ago
And yes, I think it's safe for 3.4.
Flags: approval3.4+
Flags: approval+
Target Milestone: Bugzilla 3.6 → Bugzilla 3.4

Comment 4

8 years ago
Oh, and as I said on IRC, don't forget to clear the cache in remove_from_db() too.
(Assignee)

Comment 5

8 years ago
I did the checkin fix.

Checking in Bugzilla/Status.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Status.pm,v  <--  Status.pm
new revision: 1.12; previous revision: 1.11
done
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Whiteboard: [es-gnome]
You need to log in before you can comment on or make changes to this bug.