508735 - An error message on the file upload interface is garbled

Status: VERIFIED DUPLICATE of bug 504930

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Kohei Yoshino [:kohei]]

An add-on author reported that he encountered a garbled error message when uploading a new file. I confirmed the issue -- the message could be found at

https://addons.mozilla.org/ja/developers/versions/addfile/<VersionID>
https://addons.mozilla.org/ja/developers/versions/add/<AddonID>

It's between "Oops! There seems to be a problem with this file..." and "Please correct this problem and upload your file again." and is loaded via JSON.

Screenshots and patch will follow.

Comment 1

[Kohei Yoshino [:kohei]]

Attachment: Screenshot of error message 1

This is msgid "devcp_error_updateurl"

"addons.mozilla.org 以外の updateURL を指定することはできません。install.rdf"
"ファイルから updateURL を削除した上で、再度アップロードしてください。"

Comment 2

[Kohei Yoshino [:kohei]]

Attachment: Screenshot of error message 2

This is msgid "devcp_update_addon_version_exists_error"

"アップロードされたバージョン (%1$s) は既に存在します。このバージョンに他の"
"ファイルを追加するには、<a href=\"%2$s\">ここをクリック</a> してください。"

Comment 3

[Kohei Yoshino [:kohei]]

Attachment: patch

The problem is caused by custom urldecode function in developer.js. Just use built-in decodeURI() instead.

Comment 4

[Kohei Yoshino [:kohei]]

Attachment: patch v2

Nope, the cause is unescape().

Comment 5

[Kohei Yoshino [:kohei]]

The messages above are Japanese but this problem may reproduce in other non-ascii languages.

Comment 6

[Fred Wenzel [:wenzel]]

Comment on attachment 392877 [details] [diff] [review]
patch v2

Kohei, thank you for figuring out this problem. I was working on the very same problem in bug 504930. The solution, in my opinion, is not fixing the URI decoding, but using proper JSON escaping in the first place. I have a patch ready for this. Sorry for not accepting your patch because of this.