Closed
Bug 508757
Opened 16 years ago
Closed 11 years ago
About Mozilla Firefox window: image offset
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
INVALID
People
(Reporter: gelosi, Assigned: markus)
Details
(Whiteboard: [polish-easy] [polish-visual][polish-p2])
Attachments
(3 files, 1 obsolete file)
125.30 KB,
image/png
|
Details | |
458 bytes,
patch
|
asaf
:
review-
faaborg
:
ui-review+
|
Details | Diff | Splinter Review |
75.24 KB,
image/png
|
Details |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Open "About Mozilla Firefox" window, look at the right edge of window - you see white line upside down. Guess, this gap should be removed.
Reproducible: Always
Steps to Reproduce:
1. Open "About Mozilla Firefox"
Actual Results:
see gap between firefox image and window edge
Expected Results:
All is nice
You can see screenshot at: http://yfrog.com/74picture1ccyp
Assignee | ||
Comment 1•15 years ago
|
||
Not present on Firefox 3.5.3 Mac. However, I remember this being present previously, and it is also present in trunk.
Assignee | ||
Comment 2•15 years ago
|
||
Here's the about window from mac Firefox trunk, which obviously has the annoying 1px line.
Assignee | ||
Comment 3•15 years ago
|
||
Strange… when trying a freshly downloaded 3.5.3 Mac version, the line is there, I don't know how I managed to produce the screenshot in comment 1.
Anyway, here's a simple patch to solve this minor glitch. By evaluating a few builds, I found out that the bug was not present in 2.0 but was there in 3.0. None of the changes in browser/base/aboutDialog.css/js/xul between those two versions could explain this bug.
Loading chrome://browser/content/aboutDialog.xul in a regular browser window resizes the window to the proper size, without the white line. Something seems to be happening that obstructs the about window from doing the same. So the fix for now is to lower the window width by one pixel, as in the attached patch.
Assignee: nobody → markus.magnuson
Attachment #403555 -
Attachment is obsolete: true
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #413397 -
Flags: ui-review?(faaborg)
Attachment #413397 -
Flags: review?(mano)
Updated•15 years ago
|
Attachment #413397 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Whiteboard: [polish-easy] [polish-visual][polish-p2]
Assignee | ||
Comment 4•15 years ago
|
||
Hmm, I just realized this has not been tested on Linux/Win which may not suffer from the same glitch. Who could I ask to check this out? Also, is it even possible to conditionally branch CSS files according to platform?
Assignee | ||
Comment 5•15 years ago
|
||
This is the about window from 3.5.5 on Ubuntu. I am not really sure how window borders are supposed to work on Linux, could someone with a bit more knowledge of interface guidelines and such comment on this? Should we change the width on Linux too?
The bug is still reproduced in Firefox 3.5.5 on my Mac OS X 10.5.8
Comment 7•15 years ago
|
||
Comment on attachment 413397 [details] [diff] [review]
Remove white line by reducing window width by one pixel.
In this case, the width should be set for individual elements and not for the entire dialog.
Attachment #413397 -
Flags: review?(mano) → review-
Assignee | ||
Comment 8•15 years ago
|
||
Asaf, how then should the width of the background image be related to window width?
Assignee | ||
Comment 9•15 years ago
|
||
I figure you mean that the window should not have a width set at all, is that correct?
Comment 10•15 years ago
|
||
window get sized by their content. If the content is well sized, there should not be a need to set the window's width.
Comment 11•14 years ago
|
||
This bug is now invalid and should be closed.
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•