508847 - Mops test generates datatype misalignment exceptions on winmo

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Erik Tierney]

The mops test (/test/acceptance/mops/mops.abc_) generates datatype misalignment exception on winmo.  Test should run, and pass.

The mops tests currently aren't run on WinMo, which is why we haven't noticed this before now.

Comment 1

[Erik Tierney]

Attachment: Fix unaligned data access in some of the mops methods.

Comment 2

[Steven Johnson]

Comment on attachment 394090 [details] [diff] [review]
Fix unaligned data access in some of the mops methods.

Patch looks OK, but let's confirm with Scott Petersen that the MOPS opcodes are intended to allow unaligned access. (Unfortunate if so, would have been useful to require alignment, but if not, oh well...)

Comment 3

[Steven Johnson]

Scott Petersen confirms the current opcodes are intended to allow unaligned access, so let's land this. (This will have unfortunate implications for the JIT implementation of these on ARM, but oh well...)

Comment 4

[Erik Tierney]

pushed: http://hg.mozilla.org/tamarin-redux/rev/64403db2e965

Comment 5

[Tom Donovan]

Needed for Arm/Linux too. Fixes SIGILL crash in MethodEnv::lf32() with non-aligned addresses.

Comment 6

[Chris Peyer]

Resolved fixed engineering / work item that has been pushed.  Setting status to verified.

Comment 7

[Brent Baker]

QE: In order for this bug to be properly tested on windows mobile in the autobuild this bug# 522476 needs to be fixed.

removing QRB request, bug resolved/verified

Comment 8

[Brent Baker]

removing in-testsuite?, using bug# 549296 to track adding mops test to ARM runs to ensure data alignment issue is regressed on all runs