508879 - version_win.pl returns float in daysFromBuildID() which causes mingw windres to fail

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[cls]

Attachment: v1.0 [Checkin: Comment 1+2 & 5]

In daysFromBuildID(), version_win.pl returns the value as:
     return (POSIX::mktime(00, 00, 00, $d, $m - 1, $y - 1900) -
             POSIX::mktime(00, 00, 00, 01, 00, 100)) / $secondstodays;

The return value is treated as a float.  This causes windres (2.19.1 at least) to fail with the error:

i686-pc-mingw32-windres: /opt/cls/src/moz/main/obj-x-mingw-ff/xpcom/typelib/xpidl/module.rc:54: syntax error

and module.rc contains:

1 VERSIONINFO
 FILEVERSION    1,9,0,3504.95833333333
 PRODUCTVERSION 1,9,0,3504.95833333333

I see this in CVS & comm-central.

The attached patch makes the function return an int.

Comment 1

[cls]

Checking in config/version_win.pl;
/cvsroot/mozilla/config/version_win.pl,v  <--  version_win.pl
new revision: 3.18; previous revision: 3.17
done

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/21003db404c6

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 393017 [details] [diff] [review]
v1.0
[Checkin: Comment 1+2 & 5]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e1c7b07da858
(Bv1) Keep /js/src/config/ in sync; bustage fix

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> I see this in CVS & comm-central.

I wonder why mozilla-central doesn't need this...

Comment 4

[cls]

(In reply to comment #3)
> (In reply to comment #0)
> > I see this in CVS & comm-central.
> 
> I wonder why mozilla-central doesn't need this...

I never explicitly tested the mozilla-central repo.  I was under the impression from https://developer.mozilla.org/En/Developer_Guide/Source_Code/Mercurial that mozilla-central was pulled as part of comm-central .

Comment 5

[cls]

http://hg.mozilla.org/mozilla-central/rev/83de9673213e

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> I was under the impression
> from https://developer.mozilla.org/En/Developer_Guide/Source_Code/Mercurial
> that mozilla-central was pulled as part of comm-central .

Ah: "By pulling comm-central you also get mozilla-central (or mozilla-1.9.1)".
I'll rewrite it to be more explicit: m-1.9.1 by default, currently.

(In reply to comment #5)
> http://hg.mozilla.org/mozilla-central/rev/83de9673213e

And I guess you want it on m-1.9.2 too now...