UMR: nsLocalStringService::GetBundle()

VERIFIED FIXED

Status

MailNews Core
Internationalization
P3
normal
VERIFIED FIXED
18 years ago
9 years ago

People

(Reporter: Bruce Mitchener, Assigned: (not reading, please use seth@sspitzer.org instead))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
67 nsLocalStringService::GetBundle(nsIStringBundle **aResult)
 68 {
 69   NS_ENSURE_ARG_POINTER(aResult);
 70   nsresult rv;
 71   if (!mLocalStringBundle)
 72     rv = InitializeStringBundle();
 73   NS_ENSURE_SUCCESS(rv, rv);

If mLocalStringBundle, rv -> uninitialized.  Please initialize on line 70?

 74 
 75   *aResult = mLocalStringBundle;
 76   NS_IF_ADDREF(*aResult);
 77   return NS_OK;
 78 }

Comment 1

18 years ago
Reassign to alecf.
Assignee: nhotta → alecf

Comment 2

17 years ago
Created attachment 18899 [details] [diff] [review]
proposed fix

Comment 3

17 years ago
easy fix. cc sspitzer and mscott for r=/sr=
Status: NEW → ASSIGNED

Comment 4

17 years ago
sr=mscott

Comment 5

17 years ago
seth will take care of this with another patch he has
Assignee: alecf → sspitzer
Status: ASSIGNED → NEW
fix checked in.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 7

17 years ago
Belatedly I am going to verify the fix on this bug.
The fix was checked in connection with Bug 59617, which
makes it possible to initialize uninitialized variable. See:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsLocalStringBundle.cpp&root=/cvsroot&sub
dir=mozilla/mailnews/local/src&command=DIFF_FRAMESET&rev1=1.7&rev2=1.8

Marking it verified as fixed.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.