Closed Bug 508940 Opened 11 years ago Closed 11 years ago

Share colors and background rules in a central file

Categories

(Toolkit :: Themes, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file, 1 obsolete file)

From bug 508739 comment 1:
> Could the colors be #defined in some central place or could the background
> rules be grouped in global classes? Hard-coded colors tend to get out of sync
> if they are scattered all over the place.
Depends on: 508942
Attached patch wip (obsolete) — Splinter Review
Before I continue to go down that path, is this really something that we want?
Seems to be the right approach to me.
I didn't think the preprocessor did that kind of substitution, but if it works it looks good to me!

I wonder whether we want to actually ship the file and @import it where it's needed, rather than including at build-time...
I don't think that will work. As soon as the file has been preprocessed, the #defines are gone from that file, so we'd be importing an empty file.
Attached patch v1Splinter Review
This is on top of bug 508728.

I also made some changes to the colors of selected sidebar items and added graphite support.
Attachment #393116 - Attachment is obsolete: true
Attachment #395509 - Flags: review?(dao)
Comment on attachment 395509 [details] [diff] [review]
v1

I wonder if we should share whole property sets rather than single values. Anyway, this is a great start.

>+#placesList:-moz-system-metric(mac-graphite-theme) treechildren::-moz-tree-row(selected) {

This should be #placesList:-moz-system-metric(mac-graphite-theme) > treechildren. Please also fix up nearby selectors using the same pattern.
Attachment #395509 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/c7c86b4bde71
http://hg.mozilla.org/mozilla-central/rev/73808eec9e7c

(In reply to comment #7)
> I wonder if we should share whole property sets rather than single values.

I think we should; it will be easier after bug 508942.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.