508964 - Update Arguments object to match ES5 spec

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[rspeyer]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_7; en-US) AppleWebKit/532.0 (KHTML, like Gecko) Chrome/3.0.196 Safari/532.0
Build Identifier: Rhino 1.7 release 2 2009 03 22

As per 10.6 of the spec:
- arguments' prototype should be Array.prototype
- arguments.constructor should be Object
- arguments.toString and .toLocaleString should call the corresponding methods on Object.prototype, passing arguments as the 'this' value
- arguments' internal [[Class]] should be "Arguments"

Reproducible: Always

Comment 1

[rspeyer]

Attachment: made arguments object inherit from Array, excepting constructor, toString and toLocaleString properties

Also made internal class "Arguments"

Comment 2

[rspeyer]

Attachment: Made arguments work with defineProperty and getOwnPropertyDescriptor

Also refactored somewhat internally to make the code easier to follow.

Comment 3

[Norris Boyd]

Checking in src/org/mozilla/javascript/Arguments.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/Arguments.java,v  <--  Arguments.java
new revision: 1.35; previous revision: 1.34
done
Checking in src/org/mozilla/javascript/ScriptableObject.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/ScriptableObject.java,v  <--  ScriptableObject.java
new revision: 1.159; previous revision: 1.158
done
Checking in testsrc/opt-1.tests;
/cvsroot/mozilla/js/rhino/testsrc/opt-1.tests,v  <--  opt-1.tests
new revision: 1.9; previous revision: 1.8
done
Checking in testsrc/opt0.tests;
/cvsroot/mozilla/js/rhino/testsrc/opt0.tests,v  <--  opt0.tests
new revision: 1.9; previous revision: 1.8
done
Checking in testsrc/opt9.tests;
/cvsroot/mozilla/js/rhino/testsrc/opt9.tests,v  <--  opt9.tests
new revision: 1.9; previous revision: 1.8
done
RCS file: /cvsroot/mozilla/js/rhino/testsrc/doctests/arguments.doctest,v
done
Checking in testsrc/doctests/arguments.doctest;
/cvsroot/mozilla/js/rhino/testsrc/doctests/arguments.doctest,v  <--  arguments.doctest
initial revision: 1.1
done

Comment 4

[Marc]

I think that this patch is wrong at least for one point. As far as I understand the spec, the prototype should NOT be Array prototype but Object prototype:

Point 6 of section 10.6:

"Set the [[Prototype]] internal property of obj to the standard built-in Object prototype object (15.2.4)."

I don't have the right to reopen this issue :-(

Comment 5

[rspeyer]

Attachment: make the prototype of arguments objects be Object.prototype

The spec changed since this bug was originally filed, such that the prototype of arguments objects is again Object.prototype. Changed the code to reflect that.

Comment 6

[rspeyer]

Attachment: make the prototype of arguments objects be Object.prototype

no need for special handling of toString or toLocaleString any more, as the prototype of arguments is Object.prototype

Comment 7

[Norris Boyd]

Committed, thanks!

Checking in src/org/mozilla/javascript/Arguments.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/Arguments.java,v  <--  Arguments.java
new revision: 1.36; previous revision: 1.35
done
Checking in testsrc/doctests/arguments.doctest;
/cvsroot/mozilla/js/rhino/testsrc/doctests/arguments.doctest,v  <--  arguments.doctest
new revision: 1.2; previous revision: 1.1
done