508967 - Dragging a URL or bookmark onto a tag folder in the bookmark toolbar should add that tag to it

Status: RESOLVED INACTIVE

(Firefox :: Bookmarks & History, enhancement)

Description

[Dave Miller [:justdave]]

I dragged a couple tags into my bookmark toolbar a while back...  works conveniently, shows me a list of bookmarks with that tag on it.  But the UI looks just like a bookmark folder, so it confused me when it didn't work the same (because I forgot it was a tag folder).

I tried to drag a new URL into that folder, and it wouldn't let me.  I was about to file a bug that dragging into bookmark folders on the toolbar was broken.  But then I discovered that it *did* work on another folder in my toolbar.

I think a good UI to avoid this confusion would be:

1) When dragging a bookmark from elsewhere to a tag folder
   a) add that tag to the bookmark
   b) if the "copy modifier key" (option on mac, probably control on Windows?) was not being held at the time, move the bookmark to Unsorted (out of its current location) to avoid the user thinking it didn't get moved (essentially making a copy will confuse them if that's not what they asked for by holding the key)

2) When dragging a URL from the URL bar into a tag folder
   a) create a bookmark in unsorted for it
   b) add that tag to it.

Comment 1

[Marco Bonardo [:mak]]

indeed, that's what should happen and what we implemented

does it work in the library? could be a sidebar only issue (even if that's strange)

Comment 2

[Marco Bonardo [:mak]]

oh wait these are detached tags, right?

Comment 3

[Marco Bonardo [:mak]]

probably the toolbar code does not consider tag queries a good drop point and does not even open them on dragover...
on the other side the code to handle drops in tags works in usual places where tags appear. the toolbar code probably needs a small fix in getDropPoint to consider tag containers as drop targets.

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch

this patch will probably bitrot against 382466. btw it's marking points we should fix.

Comment 5

[Shawn Wilsher :sdwilsh]

can we test this?

Comment 6

[Marco Bonardo [:mak]]

ops i missed this patch in the middle.

No we can't test this, we can synthesize dragstart or drop events, but it is really hard to synthesize a full drag and drop.

Comment 7

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.