508982 - XOWs call RewrapIfNeeded too many times

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Currently, XPC_XOW_GetOrSetProperty has:

    if (!XPCWrapper::GetOrSetNativeProperty(cx, obj, wn, id, vp, isSet,
                                            JS_FALSE)) {
      return JS_FALSE;
    }

    return XPC_XOW_RewrapIfNeeded(cx, obj, vp);

but GetOrSetNativeProperty already calls RewrapIfNeeded (via XPCWrapper::RewrapIfDeepWrapper). In practice, this actually works because the return values look like they're properties that don't have associated wrapped natives and we simply return, but we're doing extra work that we shouldn't have to do. Patch in a jiffy!

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/3c54e89da87d