508992 - ASSERTION: Accessibility wasn't initialized!: 'gIsAccessibilityActive' on quiting firefox

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Ginn Chen]

Stack:

=>[1] nsAccessNode::GetApplicationAccessible(), line 240 in "nsAccessNode.cpp"
  [2] mai_util_get_root(), line 438 in "nsAppRootAccessible.cpp"
  [3] atk_get_root(0xfef25e80, 0x0, 0x40, 0xfee86cb7, 0xfa532680, 0xfef24480), at 0xfaa52769 
  [4] spi_atk_bridge_exit_func(0x8047688, 0xfeffb7b4), at 0xf9bb3ab6 
  [5] _exithandle(0xfeffb7b4, 0x8051cc6, 0x0, 0x8051c7d, 0x8051c24, 0x8052c68), at 0xfee231bc 
  [6] exit(0x1, 0x8047830, 0x0, 0x8047845, 0x804785c, 0x8047870), at 0xfee13a22 

On exit, atk bridge would request root accessible.
We should give the atk root created by libgail in this case.

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 393144 [details] [diff] [review]
patch


>-    nsRefPtr<nsApplicationAccessibleWrap> root =
>-        nsAccessNode::GetApplicationAccessible();
>+    if (!nsAccessibilityService::gIsShutdown) {

I would return this early, more clean cvs history, more consistent with this method syntax.

>+      nsRefPtr<nsApplicationAccessibleWrap> root =
>+          nsAccessNode::GetApplicationAccessible();
> 
>-    if (root)
>-        return root->GetAtkObject();
>+      if (root)
>+          return root->GetAtkObject();
>+    }
> 
>     // We've shutdown, try to use gail instead
>     // (to avoid assert in spi_atk_tidy_windows())
>     if (gail_get_root)
>         return gail_get_root();

Comment 3

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/606abb99b43a

Committed as surkov suggested.

Comment 4

[Ginn Chen]

Attachment: missed a return statement when I checkin

Comment 5

[Ginn Chen]

Committed the missed return statement.

http://hg.mozilla.org/mozilla-central/rev/12c4d56931b0

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 393788 [details] [diff] [review]
missed a return statement when I checkin

a192=beltzner

Comment 7

[Ginn Chen]

Fixed 1.9.2
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/63fbb45b5ed9