509142 - Regression: Can not delete pending add-on file so that it can be replaced with a newer file.

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[KLB]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 (.NET CLR 3.5.30729)
Build Identifier: 

I tried to delete an add-on file for one of my pending add-ons so that I could replace it with a new version (adding a chrome.manifest to theme to make the new validator happy). I delete the file in question and click on "Update Versions" and when page reloads file is still there. This was not an issue a few days ago.

Reproducible: Always

Comment 1

[KLB]

It appears that the file was getting deleted, but the reference to it was still existing after the update. It was a little confusing.

Comment 2

[KLB]

I can't figure out what is going on, but it is really confusing.  Something isn't working right.  The file doesn't exist if you click on the link: https://addons.mozilla.org/en-US/firefox/downloads/file/60984/classic_compact-3.2.2-fx.jar

But it still exists on the update list at: https://addons.mozilla.org/en-US/developers/versions/edit/75326

And the add-on validator is supposedly validating it.  This is really weird.

Comment 4

[Wil Clouser [:clouserw]]

I can confirm this.  Looks like a FK constraint on the test_results table.  

SQL Error: 1451: Cannot delete or update a parent row: a foreign key constraint fails (`c_remora/test_results`, CONSTRAINT `test_results_ibfk_1` FOREIGN KEY (`file_id`) REFERENCES `files` (`id`))

SQL Error: 1451: Cannot delete or update a parent row: a foreign key constraint fails (`c_remora/files`, CONSTRAINT `files_ibfk_1` FOREIGN KEY (`version_id`) REFERENCES `versions` (`id`))

To reproduce:

1) Go to an add-on in the dev tools
2) click versions and files
3) click the remove button
4) confirm the removal

I'd like to get this in 5.0.9.

Comment 5

[RJ Walsh [:rjwalsh]]

Attachment: Deleting test results when we delete a file

Comment 6

[RJ Walsh [:rjwalsh]]

Fixed in r49039

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/developers/versions/delete/70533.