Closed Bug 509164 Opened 10 years ago Closed 10 years ago

Support mozilla-build start*.bat environment settings

Categories

(Testing Graveyard :: Sisyphus, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bc, Assigned: bc)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Sisyphus' build environment contains hand coded values for MSVC6 and MSVC8. It should instead use the environment variables defined by mozilla-build's start*.bat files. This does not yet support the 64bit batch files.
Flags: in-testsuite-
Attachment #393320 - Flags: review?(ctalbert)
Blocks: 509166
Blocks: 509167
Filed bug 509166 to add ability to perform simultaneous builds on different branches on Windows.

Filed bug 509167 to add 64bit Windows build support.
Attachment #393320 - Flags: review?(ctalbert) → review+
Comment on attachment 393320 [details] [diff] [review]
patch


>@@ -81,3 +81,3 @@ do
>         N) profilename=$OPTARG;;
>-        E) extensions=$OPTARG;;
>+        E) extensiondir=$OPTARG;;
>         d) datafiles=$OPTARG;;
>@@ -90,3 +90,3 @@ loaddata $datafiles
> if [[ -z "$product" || -z "$branch" || \
>-    -z "$executablepath" || -z "$profilename" || -z "$extensions" ]]; then
>+    -z "$executablepath" || -z "$profilename" || -z "$extensiondir" ]]; then
>     usage
I guess this is really no change from the old behavior, but it seemed a little odd to me that it requires extensions to be specified as part of the command line.  As I read this, it won't run without an extensions area being specified.  Is there some kind of default extension that must always be specified or can this be run without an extension?

Since it's no change from earlier, and it's only a comment for my own edification, r=ctalbert.
Spider is implicitly required at the moment. I actually hide most of the command line arguments through the use of the data files in data/ where exteniondir is defined for the configurations that are supported.

This is definitely something to be rethought. It is mostly the result of a poor design decision years ago.
http://hg.mozilla.org/tracemonkey/rev/b66ddcabf8ae

Checking in js/tests/bisect.sh;
/cvsroot/mozilla/js/tests/bisect.sh,v  <--  bisect.sh
new revision: 1.9; previous revision: 1.8
done
Checking in js/tests/config.sh;
/cvsroot/mozilla/js/tests/config.sh,v  <--  config.sh
new revision: 1.2; previous revision: 1.1
done
Checking in testing/sisyphus/bin/build.sh;
/cvsroot/mozilla/testing/sisyphus/bin/build.sh,v  <--  build.sh
new revision: 1.14; previous revision: 1.13
done
Checking in testing/sisyphus/bin/checkout.sh;
/cvsroot/mozilla/testing/sisyphus/bin/checkout.sh,v  <--  checkout.sh
new revision: 1.16; previous revision: 1.15
done
Checking in testing/sisyphus/bin/clobber.sh;
/cvsroot/mozilla/testing/sisyphus/bin/clobber.sh,v  <--  clobber.sh
new revision: 1.7; previous revision: 1.6
done
Checking in testing/sisyphus/bin/install-extensions.sh;
/cvsroot/mozilla/testing/sisyphus/bin/install-extensions.sh,v  <--  install-extensions.sh
new revision: 1.11; previous revision: 1.10
done
Checking in testing/sisyphus/bin/library.sh;
/cvsroot/mozilla/testing/sisyphus/bin/library.sh,v  <--  library.sh
new revision: 1.17; previous revision: 1.16
done
Checking in testing/sisyphus/bin/set-build-env.sh;
/cvsroot/mozilla/testing/sisyphus/bin/set-build-env.sh,v  <--  set-build-env.sh
new revision: 1.16; previous revision: 1.15
done
Removing testing/sisyphus/bin/set-msvc6-env.sh;
/cvsroot/mozilla/testing/sisyphus/bin/set-msvc6-env.sh,v  <--  set-msvc6-env.sh
new revision: delete; previous revision: 1.3
done
Removing testing/sisyphus/bin/set-msvc8-env.sh;
/cvsroot/mozilla/testing/sisyphus/bin/set-msvc8-env.sh,v  <--  set-msvc8-env.sh
new revision: delete; previous revision: 1.4
done
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.