Closed
Bug 509187
Opened 16 years ago
Closed 16 years ago
Use mirror transformations for rtl toolbarbutton icons
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 3.6b1
People
(Reporter: dao, Assigned: dao)
References
Details
(Keywords: memory-footprint, perf)
Attachments
(1 file)
|
284.73 KB,
patch
|
rflint
:
review+
|
Details | Diff | Splinter Review |
We used to have specific rtl back/forward icons in Winstripe 2.0, but not anymore.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #393350 -
Flags: review?(rflint)
|
|
Assignee | |
Updated•16 years ago
|
Summary: Use mirror transformations for rtl toolbar buttons → Use mirror transformations for rtl toolbarbuttons icons
|
|
Assignee | |
Updated•16 years ago
|
Summary: Use mirror transformations for rtl toolbarbuttons icons → Use mirror transformations for rtl toolbarbutton icons
|
||
Updated•16 years ago
|
Attachment #393350 -
Flags: review?(rflint) → review+
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 393350 [details] [diff] [review]
patch
Slightly scary since we don't run perf metrics on RTL builds, but hopefully the rule reduction and smaller images negate any ill effects.
|
|
Assignee | |
Comment 3•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6b1
|
||
Comment 4•16 years ago
|
||
+#back-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,
+#forward-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,
Does this work in Winstripe? It looks like these selectors don't match on Mac.
|
|
Assignee | |
Comment 5•16 years ago
|
||
It doesn't work on Mac because of type="menu-button"...
You need to log in
before you can comment on or make changes to this bug.
Description
•