Closed Bug 509187 Opened 11 years ago Closed 11 years ago

Use mirror transformations for rtl toolbarbutton icons

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3.6b1

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: memory-footprint, perf)

Attachments

(1 file)

We used to have specific rtl back/forward icons in Winstripe 2.0, but not anymore.
Attached patch patchSplinter Review
Attachment #393350 - Flags: review?(rflint)
Summary: Use mirror transformations for rtl toolbar buttons → Use mirror transformations for rtl toolbarbuttons icons
Summary: Use mirror transformations for rtl toolbarbuttons icons → Use mirror transformations for rtl toolbarbutton icons
Attachment #393350 - Flags: review?(rflint) → review+
Comment on attachment 393350 [details] [diff] [review]
patch

Slightly scary since we don't run perf metrics on RTL builds, but hopefully the rule reduction and smaller images negate any ill effects.
http://hg.mozilla.org/mozilla-central/rev/3855107f26ae
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6b1
+#back-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,
+#forward-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,

Does this work in Winstripe? It looks like these selectors don't match on Mac.
It doesn't work on Mac because of type="menu-button"...
Depends on: 518533
You need to log in before you can comment on or make changes to this bug.