509202 - Addressbar displays ssl identy in punycode with browser.identity.ssl_domain_display=1

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Stellan Klebom]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; sv-SE; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; sv-SE; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2

When browser.identity.ssl_domain_display = 1 firefox displays IDN Domains (Internationalized Domain Names) in punycode, however when the setting is 2 the same name is properly displayed

An example:

browser.identity.ssl_domain_display = 1:
xn--musikkren-kamraterna-1zb.se  https://www.musikkåren-kamraterna.se/

browser.identity.ssl_domain_display = 2:
www.musikkåren-kamraterna.se  https://www.musikkåren-kamraterna.se/


Expected result:

The identity should always be displayed properly for IDNs in trusted toplevel IDNs.


Reproducible: Always

Comment 1

[Stellan Klebom]

Since this bug report have not gotten any attention for nearly a month I nominated it as a blocker just to be seen...

Comment 2

[Shawn Wilsher :sdwilsh]

More information: we ship with browser.identity.ssl_domain_display set to 1 by default.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

We should fix this, yes. Especially if we end up getting rid of the URL in favour of showing the identity indicator (a proposal at this point, don't panic!)

Comment 4

[[e-mail]]

Yoink.

Comment 5

[[e-mail]]

Attachment: patch

Piece of cake.

Comment 6

[[e-mail]]

Attachment: patch v2

Now with test.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 469669 [details] [diff] [review]
patch v2

>diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js

>   getEffectiveHost : function() {

>+      var baseDomain =
>+        this._eTLDService.getBaseDomainFromHost(this._lastLocation.hostname);
>+      var isASCII = {};
>+      return this._IDNService.convertToDisplayIDN(baseDomain, isASCII);

Use let, and omit isASCII and just pass {} directly?

Comment 8

[[e-mail]]

http://hg.mozilla.org/mozilla-central/rev/a64bb4bf114d