509232 - Down arrow button in Clear Recent History dialog has hidden left border in XP Classic theme

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Kai de Leeuw]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a2pre) Gecko/20090808 Minefield/3.6a2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a2pre) Gecko/20090808 Minefield/3.6a2pre

The button with a down arrow in the Clear Recent History dialog is partially obscured, one or more pixels are not shown on its left side.

Reproducible: Always

Steps to Reproduce:
1. Open Tools > Clear Recent History
2. Look at the button with a down arrow, you don't see the left border of it.

Actual Results:  
Down arrow button partially obscured

Expected Results:  
Down arrow button not obscured

Comment 1

[Kai de Leeuw]

Attachment: Screen shot showing the cosmetic problem

Comment 2

[(no longer active)]

Drew, care to take a look?

Comment 3

[(no longer active)]

Confirming on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2.

Comment 4

[Drew Willcoxon :adw]

The problem (probably) is the -moz-margin-start on #detailsExpanderWrapper:
http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/sanitizeDialog.css#55

I chose that value to align the button with the list below it and the label above it on Vista.  I'm installing XP now and will ask for a license, but if anyone with access to XP wants to pitch in, please do.

Comment 5

[Dão Gottwald [:dao]]

Right, that negative margin shouldn't be there.

Comment 6

[(no longer active)]

Attachment: Patch (v1)

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 397584 [details] [diff] [review]
Patch (v1)

you can just make this margin: 6px 0;

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/e3e594837a30

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 397584 [details] [diff] [review]
Patch (v1)

Polish bugs, while virtuous, don't belong on the stable branch. In aggregate they cost more than they gain.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 397584 [details] [diff] [review]
Patch (v1)

a192=beltzner

Comment 11

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/2315796d220f

Comment 12

[Marcia Knous [:marcia]]

Verified fixed on the 1.9.2 branch using  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1pre) Gecko/20090922 Namoroka/3.6b1pre. Adding keyword.