Either document and enforce a maximum width for theme preview images, or don't horizontally compress them

RESOLVED FIXED in mozilla1.9.2

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: philor, Assigned: neil)

Tracking

Trunk
mozilla1.9.2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
If a theme's preview.png image is more than 220px wide, it's horizontally compressed down to 220px. That's hard to see in Firefox with the default theme, because winstripe and gnomestripe both have preview.pngs less than 220px wide, and pinstripe's is only 250px wide, so it's only slightly compressed, but it's really easy to see with Thunderbird on OS X, since there the image is 355x85, so the horizontal compression down to 220x85 is obvious.

It doesn't entirely make sense to me, but that's apparently the result of the 

#previewImageDeck {
  min-width: 220px;
}

added by bug 423469, since if I increase that to 355px, I get an uncompressed image in Tb/Mac.

<Mossop>: Let's start recommending a fixed size for theme previews in 3.6, then insist on it in 3.7
We'll document this for 1.9.2 (and possibly take changes if the chosen size doesn't display perfectly) then the new UI will enforce it. I'll speak to AMO about trying to keep it consistent with what they do.
Assignee: nobody → dtownsend
Target Milestone: --- → mozilla1.9.2
(Assignee)

Comment 2

9 years ago
Created attachment 393495 [details] [diff] [review]
Proposed patch
Assignee: dtownsend → neil
Status: NEW → ASSIGNED
Attachment #393495 - Flags: review?(dtownsend)
Attachment #393495 - Flags: review?(dtownsend) → review+
(Assignee)

Comment 3

9 years ago
Comment on attachment 393495 [details] [diff] [review]
Proposed patch

Pushed changeset d8d073092334 to mozilla-central.
(Assignee)

Updated

9 years ago
Assignee: neil → dtownsend
After discussion it looks like we should probably wait for the UI redesign before really fixing this so this bug is done for now. Filed bug 515600 on getting an updated pinstripe preview that fits better with the current UI.
Assignee: dtownsend → neil
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.