Closed
Bug 509264
Opened 15 years ago
Closed 15 years ago
Sisyphus - uninstall broken
Categories
(Testing Graveyard :: Sisyphus, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
Details
Attachments
(1 file)
|
2.43 KB,
patch
|
cmtalbert
:
review+
|
Details | Diff | Splinter Review |
uninstall-build.sh incorrectly checks for a current installation at the specificed location. The fix is to change: -if [[ ! ls "$executablepath/*" 2> /dev/null ]]; then +if ! ls $executablepath/* > /dev/null 2>&1; then This uncovers an existing problem with Windows zip builds where calling the Windows uninstaller will fail for zip builds. Suppressing uninstaller failures on Windows allows the target directory to be cleaned up and the uninstall to succeed.
Flags: in-testsuite-
Attachment #393396 -
Flags: review?(ctalbert)
Attachment #393396 -
Flags: review?(ctalbert) → review+
|
Assignee | |
Comment 1•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/415a18e12025 /cvsroot/mozilla/testing/sisyphus/bin/uninstall-build.sh,v <-- uninstall-build.sh new revision: 1.8; previous revision: 1.7
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•